fix: re-introduce JSDoc type casts without wrapping binding identifiers - #167
Merged
elliott-with-the-longest-name-on-github merged 3 commits intoAug 17, 2026
Merged
Conversation
This reverts commit e51f38f.
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/93d797ed676a4d9fa4a83089b2f0f18bb29396b9Open in |
🦋 Changeset detectedLatest commit: 93d797e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Aug 14, 2026
elliott-with-the-longest-name-on-github
merged commit Aug 17, 2026
51da035
into
main
6 checks passed
elliott-with-the-longest-name-on-github
deleted the
fix-jsdoc-binding-casts
branch
August 17, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
This un-reverts #165 (re-introducing the JSDoc type cast support from #162) and fixes the regression that prompted the revert.
Problem
#162 detected JSDoc type casts with the guard
node.type in EXPRESSIONS_PRECEDENCE, butIdentifier(and patterns) are in that table even when they appear in binding positions. A/** @type {...} */comment attached to theidof aVariableDeclarator— as emitted by the svelte compiler for hoistedletdeclarations in server output — was wrapped in parens, producing invalid output like:Fix
Track nodes in binding positions (variable declarator ids, function/method/arrow/TS-signature params, catch clause params) in a
WeakSetand exclude them from type cast detection. Genuine casts (const foo = /** @type {number} */ (1);) still keep their parentheses.Tests
New
comment-jsdoc-type-annotationsample covering declarator ids, multiple declarators, function/arrow params, catch params, alongside a genuine cast.