fix: disambiguate arrow function type parameters in JSX - #155
Open
MathiasWP wants to merge 1 commit into
Open
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/0112377125131496165ebf3a4d296bda76b0a841Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 0112377 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thank you! The fix looks good but the claim that this does not change public API is wrong - it's changing the public default export. I don't know how we can solve this without moving everything into a new file but I'd like to avoid adding a second parameter if possible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a JSX file, an arrow function's
<T>type parameter list is parsed as the start of a JSX element. The trailing comma that disambiguates it was dropped, so generic arrow functions printed withesrap/languages/tsxno longer compile:The comma is only added where the list is actually ambiguous — a second parameter, a constraint or a default already rules JSX out, so
<T, U>,<T extends object>and<T = string>are left alone. Modifiers (const,in,out) do not disambiguate, so<const T>gets the comma too.Two supporting changes:
ts()takes an internal second argument set by thetsxmodule, so this only affects JSX output. The public signature is unchanged.esrap.test.jsprinted every sample withtsx(), including the.tsones — it now picks the module matching the sample'sjsxMode, sots-arrow-function-typeskeeps printing plain<T>.