fix: preserve type-level syntax that was being dropped when printing - #159
Merged
manuel3108 merged 1 commit intoAug 7, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/esrap/c/e755f394528f20f4721f8ae3c67d34c6db2c3e18Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: e755f39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
manuel3108
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four visitors carried type-level information on the node but never printed it. Each is a silent change of meaning — the output still parses, so nothing surfaces until the types are wrong.
Optional tuple elements —
TSNamedTupleMember.optionalAccessor signatures —
TSMethodSignature.kindTwo accessors become two call signatures for the same method — a different (and, with differing parameter/return types, invalid) interface.
Instantiation expressions in
typeof—TSTypeQuery.typeArgumentsExplicit type arguments on JSX elements —
JSXOpeningElement.typeArgumentsBoth
@sveltejs/acorn-typescriptandoxc-parserpopulate all four properties under the same names, and both now produce identical output for each case.One incidental change:
expected.tsxis added to.prettierignore, next to theexpected.tsandexpected.jsxentries that were already there. The snapshot harness writes these files without a trailing newline, so lint fails on the first.tsxsample in the repo. #155 adds the same line for the same reason — whichever lands second will need that hunk dropped.