Repository navigation
chore(devtools): check the branch name and PR size before push - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pre-pushblock tolefthook.ymlthat runs.devtools/check-branch-name.shand.devtools/check-pr-size.sh: the same two scriptsci-prruns and.pre-commit-hooks.yamloffers to consumers.Why
This repo's own hooks only covered
commit-msgandpre-commit, so a bad branch name was first reported by CI, after the pull request was open. That is how #42 was opened fromdocs/profile-readmeand had to be replaced by #44.Tested
lefthook installnow syncspre-pushalongside the other two hooks.lefthook run pre-pushon a throwawaydocs/should-failbranch:branch-namefails with the Conventional Branch message.lefthook run pre-pushon this branch: both commands pass.bash .devtools/test-hooks.sh: all passed.Existing clones pick the hook up on their next
pnpm install.Known limit
Both scripts check the branch that is checked out, not the ref being pushed, so
git push origin <other-branch>is checked against the wrong name. CI still catches that case.