Repository navigation
fix(devtools): measure PR size against origin's default branch - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
check-pr-size.shworks the base out for itself and lands on the default branch, it now readsorigin/<default>and only falls back to the local branch when origin has none.Why
The local default branch only moves on a pull. A branch cut from a fresher
origin/mainhad its merge base at the stale localmain, so every filemaingained in between was counted as the branch's own. Seen on #45: a 2-file change reported as 4 because localmainwas one merge behind.What does not change
--base,PR_BASE) still resolves local-first, soci-prand explicit calls behave as before.origin/<default>ref, the local branch is used as before.Tested
bash .devtools/test-hooks.sh: all passed, with two new cases (origin preferred for a worked-out default branch; a named base stays local).shellcheckclean on both files.mainone commit behind: the old script reports3/20 files changed vs mainon a branch with no changes, the new one0/20 files changed vs origin/main.Known limit
It compares against origin as of the last fetch; it does not fetch. A push from a clone that has not fetched in a while can still overcount, and CI remains the real gate.