Repository navigation
GPU stack 4/8: apply separable mass matrices as Kronecker products of 1D banded matrices - #785
Open
max-models wants to merge 7 commits into
Open
max-models wants to merge 7 commits into
max-models wants to merge 7 commits into
Conversation
…ices WeightedMassOperator.dot applies the blocks of its matrix that are Kronecker products of 1D banded matrices (constant weights, e.g. on a Cuboid) as three banded passes (struphy.feec.kronecker_mass, CUDA kernel kron_band_pass on the GPU) instead of the 3D stencil product. The replacement is built on first use and invalidated by assembly, copies and in-place arithmetic; a matrix changed by arithmetic that is not a Kronecker product is not checked again. STRUPHY_KRONECKER_MASS=0 switches it off. The boundary and extraction operators around the matrix are skipped when they are identities instead of being applied as copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
max-models
added this pull request to stack #790
October 16, 2026 08:51
…ck-3-mass-assembly)
…ass (feectools update)
…ass (feectools update)
The banded passes run with the same buffers in every solver iteration (as on cuda-aware-mpi-fixes, now that feectools has CachedLaunch). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ck-3-mass-assembly)
…ass (pcg_sr in the shear Alfven solves)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 8 of the split of #772 (
cuda-aware-mpi-fixes) into stacked PRs. Requires struphy-hub/feectools#104 to be merged into feectoolsdevel-tinyfirst (PR 1 bumps the submodule).feec/kronecker_mass.py:WeightedMassOperator.dotapplies the blocks of its matrix that are Kronecker products of 1D banded matrices (constant weights, e.g. on a Cuboid) as three banded passes instead of the 3D stencil product. On the GPU this uses the new kernelkron_band_pass_cuda.cu.STRUPHY_KRONECKER_MASS=0switches it off.The replacement is built on first use and invalidated by assembly, copies and in-place arithmetic. A matrix changed by arithmetic that is not a Kronecker product (e.g. a Schur complement rebuilt every step) is not checked again.
The boundary and extraction operators around the matrix are skipped when they are identities, instead of being applied as copies.
The band-pass kernel is launched through feectools'
CachedLaunch(feectools#104): the banded passes run with the same buffers in every solver iteration, so the launch preparation is done once per set of buffers.Tests
Local, macOS without a GPU, in a fresh environment with feectools
1d8d47cand the pinned cunumpy, after merging devel (with #774 and #775). The PR passestest_cuda_parity,test_cuda_emulation,test_kernel_backends,test_sorting,test_accum_matrix_cupy,test_preconditioner_cupy,test_poissonandtest_outputon its own. The top of the stack also passes the mass-matrix, preconditioner, Derham-GPU, fused-gradient, Kronecker-block, Poisson, shear Alfvén, post-processing, polar fake-CuPy and allpictests (1477 passed), the examples test for the two profiling cases, the sorting, Poisson and fused-gradient tests undermpirun -n 2, and the device MPI sort on the fake CuPy on 2 and 4 ranks. The Kronecker products match the stencil mass matrices to 5e-16 for M0, M1, M2, M3, Mv, M1n and M2n on a Cuboid, periodic and Dirichlet, on 1 and 2 ranks.Not tested on a GPU here. The CUDA kernels and the device paths need a run on the cluster.
Stack (merge in order)
devel-tiny)devel🤖 Generated with Claude Code