Repository navigation
GPU stack 1/8: update feectools (device ghost exchange, single-reduction PCG); pcg_sr solver option - #782
Open
max-models wants to merge 6 commits into
Open
GPU stack 1/8: update feectools (device ghost exchange, single-reduction PCG); pcg_sr solver option#782max-models wants to merge 6 commits into
max-models wants to merge 6 commits into
Conversation
… add the pcg_sr solver option feectools: struphy-hub/feectools#104 (fix-cuda-aware-mpi-issues into devel-tiny). pcg_sr (PConjugateGradientSingleReduction) is accepted wherever pcg is, including the preconditioned solvers of the Poisson, diffusion, curl-curl and variational propagators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
Open
max-models
added this pull request to stack #790
October 16, 2026 08:51
feectools b70cb6c (struphy-hub/feectools#104): the emulated GPU tests (fake CuPy) failed at the first stencil product. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
feectools 1d8d47c (struphy-hub/feectools#104). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 8 of the split of #772 (
cuda-aware-mpi-fixes) into stacked PRs. Requires struphy-hub/feectools#104 to be merged into feectoolsdevel-tinyfirst (PR 1 bumps the submodule).Merge struphy-hub/feectools#104 (feectools
fix-cuda-aware-mpi-issuesintodevel-tiny) first. This PR points thefeectoolssubmodule at that branch (commit1d8d47c).PConjugateGradientSingleReduction, fasterstencil_dot_3don the GPU (details in the feectools PR).pcg_sris accepted whereverpcgis (LiteralOptions.OptsSymmSolver), also with a preconditioner: Poisson, ImplicitDiffusion, GyrokineticPoissonSolve, CurlCurlSolve, VariationalDensityEvolve, VariationalMomentumAdvection. Same iterates aspcg, one global reduction per iteration instead of two.Tests
Local, macOS without a GPU, in a fresh environment with feectools
1d8d47cand the pinned cunumpy, after merging devel (with #774 and #775). The PR passestest_cuda_parity,test_cuda_emulation,test_kernel_backends,test_sorting,test_accum_matrix_cupy,test_preconditioner_cupy,test_poissonandtest_outputon its own. The top of the stack also passes the mass-matrix, preconditioner, Derham-GPU, fused-gradient, Kronecker-block, Poisson, shear Alfvén, post-processing, polar fake-CuPy and allpictests (1477 passed), the examples test for the two profiling cases, the sorting, Poisson and fused-gradient tests undermpirun -n 2, and the device MPI sort on the fake CuPy on 2 and 4 ranks. The Kronecker products match the stencil mass matrices to 5e-16 for M0, M1, M2, M3, Mv, M1n and M2n on a Cuboid, periodic and Dirichlet, on 1 and 2 ranks.Not tested on a GPU here. The CUDA kernels and the device paths need a run on the cluster.
Stack (merge in order)
devel-tiny)devel🤖 Generated with Claude Code