Skip to content

fix(scaleway): a comment about the gateway's 404 outlived the line that fixed it #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephrobert merged 1 commit into from
Sep 15, 2026
Merged

fix(scaleway): a comment about the gateway's 404 outlived the line that fixed it #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions internal/providers/scaleway/gateway_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,22 @@ func TestTheGatewayMetadataDoesNotVary(t *testing.T) {
// And it is a GET: the SDK issues no other verb at this path, so anything
// else must not be served here by accident.
//
// Read with a bare client rather than the shared helper, which decodes JSON
// and fails on this answer — because an unmounted path answers net/http's
// plain-text "404 page not found". The real gateway answers a Scaleway error
// document there (`{"type":"404","message":…}`, measured 2026-09-14). That
// divergence is real and belongs to every unmounted path rather than to this
// route, so it is named in #776 and not fixed here; this assertion is about
// the verb, and it is written not to depend on a body it is not judging.
res, err := ts.Client().Post(ts.URL+"/metadata", "application/json", nil) //nolint:noctx // test client
if err != nil {
t.Fatalf("POST /metadata: %v", err)
}
defer func() { _ = res.Body.Close() }()
if res.StatusCode == http.StatusOK {
// What it answers instead is this pack's own refusal, and that is worth
// asserting rather than merely "not 200": declaring `/metadata` in
// productPrefixes is what buys it. Before that line, a POST here fell
// through to net/http and came back as plain-text "404 page not found" —
// which the SDK drops, leaving a caller with a bare status and nothing to
// branch on. That is #74's finding, and this route is inside it.
//
// Measured both ways on 2026-09-15: without the prefix, `404 page not
// found`; with it, `501 {"type":"not_emulated", …}`.
status, body := do(t, ts, "POST", "/metadata", "")
if status == http.StatusOK {
t.Error("POST /metadata answered 200; the gateway serves a read")
}
if body["type"] != "not_emulated" {
t.Errorf("POST /metadata answered %v, not this pack's refusal. A path inside "+
"a declared prefix must answer in Scaleway's dialect, or the SDK drops "+
"the body and the caller gets a bare status", body)
}
}
8 changes: 8 additions & 0 deletions tools/falsify/specs/the-gateway-is-served-and-scanned.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@
"find": "\t\"/metadata\",",
"replace": "\t\"/metadata-not-declared\",",
"test": "TestEveryRouteFallsUnderADeclaredPrefix"
},
{
"label": "the gateway path leaves the declared space, so a POST near it answers net/http's plain text and the SDK hands its caller a bare status",
"file": "internal/providers/scaleway/pack.go",
"package": "./internal/providers/scaleway/",
"find": "\t\"/metadata\",",
"replace": "\t\"/metadata-not-declared-either\",",
"test": "TestTheGatewayMetadataDoesNotVary"
}
]
}
Loading