fix(scaleway): a comment about the gateway's 404 outlived the line that fixed it - #783
Merged
Merged
Conversation
…at fixed it TestTheGatewayMetadataDoesNotVary carried a note saying that a POST to `/metadata` answers net/http's plain-text "404 page not found", that the real gateway answers a Scaleway error document there, and that the divergence was left to #776. All three sentences were true when they were written and the first was false by the time they were committed: declaring `/metadata` in productPrefixes — in the same change — is exactly what stops that path falling through to net/http. The comment described a state its own pull request had removed. Measured both ways on 2026-09-15: without the prefix 404 page not found (text/plain) with it 501 {"type":"not_emulated", …} So the assertion is strengthened rather than the comment reworded. It was "not 200", which passes for a bare status the SDK drops; it now names the refusal this pack owes a client inside its declared space, which is #74's finding and the reason the prefix list exists. The existing mutation on that prefix reddens TestEveryRouteFallsUnderADeclaredPrefix, which is a statement about the route table. This adds the one that reddens the behaviour a client sees, and it bites: seven mutations, all of them. Assisted-by: Claude Code (claude-opus-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestTheGatewayMetadataDoesNotVarycarried a note saying that a POST to/metadataanswers net/http's plain-text404 page not found, that the realgateway answers a Scaleway error document there, and that the divergence was
left to #776.
All three sentences were true when they were written, and the first was false by
the time they were committed: declaring
/metadatainproductPrefixes— inthe same pull request — is exactly what stops that path falling through to
net/http. The comment described a state its own change had removed.
Measured both ways on 2026-09-15:
404 page not found(text/plain)501 {"type":"not_emulated", …}What changes
The assertion is strengthened rather than the comment reworded. It was
!= 200, which passes for a bare status the SDK drops; it now names the refusalthis pack owes a client inside its declared space — which is #74's finding and
the reason the prefix list exists at all.
The existing mutation on that prefix reddens
TestEveryRouteFallsUnderADeclaredPrefix,a statement about the route table. This adds the one that reddens the
behaviour a client sees. Seven mutations now, all biting.
mise run prepushgreen.🤖 Generated with Claude Code