Repository navigation
Complete teaching corrections, candidate review and explicit adoption - #4
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Correcting a taught skill previously required manual candidate management, and editing the document demo's lessons could disable its working skill. This adds a shared
TeachingSessionworkflow: record an explicit correction, assess a separate candidate, inspect the before/after results, and deliberately adopt the exact passing artifact. The approved skill remains available during edits and failed assessments.system1 teachCLI and legacyrefleximport parity for one textChoiceFieldwith uncertainty review enabled. Reject stale or altered evidence and incompatible schemas.Existing prediction algorithms, compiler/engine APIs,
.s1mformat, required dependencies and package version remain unchanged.Real-document evidence
The frozen BBC experiment separates initial lessons, calibration, adoption checks, feedback and a 400-article final holdout, with duplicate grouping before splitting and an ordinary-extra-lessons control. Adding 64 targeted feedback lessons reduced accepted mistakes from 16 to 8 while increasing reviews from 27 to 63. Raw accuracy rose from 92.25% to 93.25%, but its paired interval includes no gain.
All three candidates failed the unchanged zero-error development adoption gate; none was adopted. The evidence supports an error/review tradeoff, not general classifier superiority or successful adoption on real data. The protocol, full text-free outcomes, split manifest and exact measured source snapshot are retained in
benchmarks/quality/document_workflow/.Validation
reflexalias work outside the checkout without SciPy.Scope is a single-writer local workspace for one text-choice skill. Default adoption thresholds are demonstration defaults, not a production accuracy guarantee. This PR does not bump or publish a release.