Skip to content

fix: Address E2E test review issues #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepandel merged 1 commit into from
Feb 4, 2026
Merged

fix: Address E2E test review issues #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/connection-flow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ test.describe('E2E-002: Connection Flow Tests', () => {
id,
name: 'Invalid Key Test',
provider: 'pinecone' as const,
apiKey: 'invalid-api-key-12345',
apiKey: 'invalid-api-key-for-tests', // gitleaks:allow
}

try {
Expand Down
2 changes: 1 addition & 1 deletion e2e/electron.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export async function createPineconeTestProfile(
): Promise<string> {
const profileId = `test-pinecone-${Date.now()}`
const profileName = name || `Test Pinecone ${Date.now()}`
const pineconeKey = apiKey || process.env.PINECONE_API_KEY || 'dummy-key-for-local-testing'
const pineconeKey = apiKey || process.env.PINECONE_API_KEY || 'dummy-key-for-local-testing' // gitleaks:allow

await page.evaluate(
async ({ id, name, apiKey }) => {
Expand Down
19 changes: 10 additions & 9 deletions e2e/index-collection-management.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,16 +182,17 @@ test.describe('E2E-003: Index/Collection Management Tests', () => {
await (window as any).electronAPI.pinecone.createIndex(id, params)
}, { id: testProfileId, params: createParams })

// Wait for index to be created and become ready
// Pinecone indexes can take a while to initialize
await page.waitForTimeout(5000)

// Verify index was created by listing indexes
const indexes = await page.evaluate(async (id) => {
return await (window as any).electronAPI.pinecone.listIndexes(id)
}, testProfileId)
// Poll for index to become ready (can take 30-60+ seconds for serverless)
let createdIndex: any
await expect(async () => {
const indexes = await page.evaluate(async (id) => {
return await (window as any).electronAPI.pinecone.listIndexes(id)
}, testProfileId)
createdIndex = indexes.find((idx: any) => idx.name === testIndexName)
expect(createdIndex).toBeDefined()
expect(createdIndex?.status?.ready).toBe(true)
}).toPass({ timeout: 90000, intervals: [5000] })

const createdIndex = indexes.find((idx: any) => idx.name === testIndexName)
expect(createdIndex).toBeDefined()
expect(createdIndex?.dimension).toBe(384)
expect(createdIndex?.metric).toBe('cosine')
Expand Down