fix: Address E2E test review issues

[stepandel]

Summary

Addresses critical issues identified in PR reviews before merging.

Fixes

1. Index creation timeout (from PR feat(PINE-29): E2E index/collection management tests #27 review)

   • Changed from fixed 5s wait to polling with 90s timeout
   • Now properly checks status.ready before proceeding
   • Pinecone serverless indexes can take 30-60+ seconds

2. Gitleaks false positives (from PR feat(PINE-31): E2E-005 vector browsing tests #29 review)

   • Added // gitleaks:allow comments to test API key strings
   • Prevents CI failures from secret scanning

Files Changed

• e2e/index-collection-management.spec.ts - Polling for index readiness
• e2e/connection-flow.spec.ts - Gitleaks allowlist comment
• e2e/electron.setup.ts - Gitleaks allowlist comment

Summary by CodeRabbit

• Tests
  • Enhanced test reliability for index creation validation with improved readiness checks.
  • Updated test data security measures.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR refines end-to-end tests by updating test data strings, adding gitleaks security annotations, and improving index creation verification with a polling-based readiness check instead of a fixed wait.

Changes

Cohort / File(s)	Summary
Test Data & Security Annotations e2e/connection-flow.spec.ts, e2e/electron.setup.ts	Updated invalid Pinecone API key test string from 'invalid-api-key-12345' to 'invalid-api-key-for-tests' and added // gitleaks:allow inline comments to suppress false-positive secret scanning alerts.
Index Creation Verification e2e/index-collection-management.spec.ts	Replaced fixed 5-second wait after index creation with a polling-based readiness check that repeatedly queries index status with 5-second intervals (90-second timeout) to confirm status.ready is true before proceeding with assertions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• PR #29: Directly updates the same e2e/index-collection-management.spec.ts file to implement the polling-based readiness check for index creation validation.
• PR #28: Modifies overlapping e2e test files (e2e/connection-flow.spec.ts and e2e/index-collection-management.spec.ts) with related test improvements.
• PR #27: Changes the same test file with comparable index readiness verification logic enhancements.

Poem

🐰 A test that waits with patient polls,
Checking if the index fills its goals,
With gitleaks whispers, keys obscured so well,
The ready status now rings true—no more to tell! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: Address E2E test review issues' is vague and generic, using non-descriptive language that doesn't convey the specific nature of the changes.	Consider a more specific title that highlights the main technical change, such as 'fix: Replace fixed E2E index creation wait with polling and add gitleaks annotations' or 'fix: Add polling readiness check for Pinecone index creation in E2E tests'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/e2e-review-issues

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.