Skip to content

Remove cloudflare api token secret from cert-manager_cloudflare module #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steled merged 1 commit into from
Nov 6, 2026
Merged

Remove cloudflare api token secret from cert-manager_cloudflare module #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cert-manager_cloudflare/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ No modules.
| [kubernetes_manifest.cert_manager_cluster_issuer_selfsigned_issuer](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/manifest) | resource |
| [kubernetes_manifest.cert_manager_cluster_issuer_steled_ca_issuer](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/manifest) | resource |
| [kubernetes_namespace_v1.certmanager](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/namespace_v1) | resource |
| [kubernetes_secret_v1.cloudflare_api_token_secret](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/secret_v1) | resource |

## Inputs

Expand All @@ -38,7 +37,6 @@ No modules.
| <a name="input_cert_manager_email"></a> [cert\_manager\_email](#input\_cert\_manager\_email) | n/a | `string` | n/a | yes |
| <a name="input_cert_manager_values_yaml"></a> [cert\_manager\_values\_yaml](#input\_cert\_manager\_values\_yaml) | Path to the cert-manager values.yml file, relative to the root module | `string` | n/a | yes |
| <a name="input_cert_manager_version"></a> [cert\_manager\_version](#input\_cert\_manager\_version) | Set the version of cert-manager | `string` | n/a | yes |
| <a name="input_cloudflare_api_token"></a> [cloudflare\_api\_token](#input\_cloudflare\_api\_token) | n/a | `string` | n/a | yes |
| <a name="input_namespace"></a> [namespace](#input\_namespace) | Name of the kubernetes namespace | `string` | n/a | yes |
| <a name="input_namespace_annotations"></a> [namespace\_annotations](#input\_namespace\_annotations) | Additional annotations for the namespace | `map(string)` | `{}` | no |
| <a name="input_namespace_labels"></a> [namespace\_labels](#input\_namespace\_labels) | Additional labels for the namespace | `map(string)` | `{}` | no |
Expand Down
2 changes: 0 additions & 2 deletions cert-manager_cloudflare/cert-manager.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@ resource "helm_release" "certmanager" {
when = destroy
command = "kubectl delete crd certificaterequests.cert-manager.io certificates.cert-manager.io challenges.acme.cert-manager.io clusterissuers.cert-manager.io issuers.cert-manager.io orders.acme.cert-manager.io"
}

depends_on = [kubernetes_secret_v1.cloudflare_api_token_secret]
}
4 changes: 0 additions & 4 deletions cert-manager_cloudflare/clusterissuer_letsencrypt.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
# YAML

# depends_on = [
# kubernetes_secret_v1.cloudflare_api_token_secret,
# helm_release.certmanager
# ]
# }
Expand Down Expand Up @@ -55,7 +54,6 @@ resource "kubernetes_manifest" "cert_manager_cluster_issuer_letsencrypt_staging"
}

depends_on = [
kubernetes_secret_v1.cloudflare_api_token_secret,
helm_release.certmanager
]
}
Expand All @@ -81,7 +79,6 @@ resource "kubernetes_manifest" "cert_manager_cluster_issuer_letsencrypt_staging"
# YAML

# depends_on = [
# kubernetes_secret_v1.cloudflare_api_token_secret,
# helm_release.certmanager
# ]
# }
Expand Down Expand Up @@ -117,7 +114,6 @@ resource "kubernetes_manifest" "cert_manager_cluster_issuer_letsencrypt_producti
}

depends_on = [
kubernetes_secret_v1.cloudflare_api_token_secret,
helm_release.certmanager
]
}
15 changes: 0 additions & 15 deletions cert-manager_cloudflare/secret.tf
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions cert-manager_cloudflare/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ variable "cert_manager_values_yaml" {
description = "Path to the cert-manager values.yml file, relative to the root module"
}

variable "cloudflare_api_token" {
type = string
}

variable "cert_manager_email" {
type = string
}
Expand Down
Loading