Repository navigation
Remove cloudflare api token secret from cert-manager_cloudflare module - #154
Merged
Merged
Conversation
The secret is managed by ArgoCD via a SealedSecret. Managing it in Terraform as well caused a permanent diff on the argocd tracking-id annotation set by the sealed-secrets controller. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: steled <34886888+steled@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The module created the secret
cert-manager/cloudflare-api-token, and ArgoCD (helm-cert-manager) deploys aSealedSecretwith the same name. The sealed-secrets controller adopts the existing Secret and copies theargocd.argoproj.io/tracking-idannotation onto it. Terraform then showed a permanent diff on that annotation.Change
kubernetes_secret_v1.cloudflare_api_token_secret(secret.tf)cloudflare_api_tokendepends_onreferences to the secretThe secret is now managed solely by the SealedSecret in ArgoCD.
Migration
Callers must drop
cloudflare_api_tokenfrom the module call and runterraform state rm module.<name>.kubernetes_secret_v1.cloudflare_api_token_secretbefore applying, otherwise the secret gets destroyed.Note: on a fresh cluster, certificates are only issued once ArgoCD has synced the SealedSecret (requires the sealed-secrets key to be restored).
🤖 Generated with Claude Code