Skip to content

fix(photo-annotator): restore text/callout/measurement inline input #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steilerDev merged 2 commits into from
May 19, 2026
Merged

fix(photo-annotator): restore text/callout/measurement inline input #1528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8385da7
fix(photo-annotator): restore text/callout/measurement inline input
May 19, 2026
d6a7f53
ci: retrigger flaky App.test
May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions client/src/components/photos/PhotoAnnotator/PhotoAnnotator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,17 +499,27 @@ export function PhotoAnnotator({ photo, onSave, onCancel }: PhotoAnnotatorProps)
if (liveRegionRef.current) {
liveRegionRef.current.textContent = t('shapeAddedFreehand');
}
} else if (state.selectedTool === 'text') {
// Text tool: click-to-place, no drag size requirement
openInlineInput(draftShape.startX, draftShape.startY);
} else if (state.selectedTool === 'callout') {
// Callout: requires minimum drag (rect with tail)
if (w > MIN_SIZE && h > MIN_SIZE) {
openInlineInput(draftShape.startX, draftShape.startY);
} else {
setDraftShape(null);
}
} else if (state.selectedTool === 'measurement') {
// Measurement: line-based, use Euclidean distance gate
const distance = Math.hypot(draftShape.endX - draftShape.startX, draftShape.endY - draftShape.startY);
if (distance > MIN_SIZE) {
openInlineInput(draftShape.startX, draftShape.startY);
} else {
setDraftShape(null);
}
} else if (w > MIN_SIZE && h > MIN_SIZE) {
const newShape = createShapeFromDraft(draftShape);
if (
newShape &&
(state.selectedTool === 'text' ||
state.selectedTool === 'callout' ||
state.selectedTool === 'measurement')
) {
// These require text input
openInlineInput(draftShape.startX, draftShape.startY);
} else if (newShape) {
if (newShape) {
undoStack.commit(undoStack.shapes.concat([newShape as AnnotationShape]));
setDraftShape(null);
const announcements: Record<ToolName, string> = {
Expand Down