fix(photo-annotator): restore text/callout/measurement inline input#1528
Merged
Conversation
The text, callout, and measurement tools were not opening the inline text input when drawn on the canvas. The issue was in handleStageMouseUp which checked createShapeFromDraft return value, but that function doesn't handle these tools. Fixed by restructuring handleStageMouseUp to dispatch to inline input based on tool type directly: - Text: click-to-place (no drag size requirement) - Callout: open input when drag exceeds MIN_SIZE in both axes - Measurement: open input when Euclidean distance exceeds MIN_SIZE Co-Authored-By: Claude frontend-developer (claude-haiku-4-5) <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 2.6.0-beta.63 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text, Callout, and Measurement tools were not opening the inline text input when drawn. The dispatch logic in handleStageMouseUp was broken — it checked createShapeFromDraft return value, but that function doesn't handle these three tools.
Solution
Restructured handleStageMouseUp to dispatch inline input based on tool type directly:
Verification
All 32 existing tests pass locally.