Repository navigation
ci: re-pin acceptance-spec to 380780e (base cache now works); convention gate waits for acceptance-spec#5 - #2249
Conversation
…ention.yml Re-pin to 380780e255019826deb3901987f4004a454a7659 (waivable-paths input, base cache fix). ci / acceptance convention now calls convention.yml with Saiku's exact waiver list; the local acceptance-check.mjs and the convention logic in acceptance-spec.mjs are removed, acceptance/2172 is ported to assert the ci.yml wiring. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Semantic model diffNo semantic model changed in this pull request, so there was nothing to diff. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
…alling job shadows the required ci check) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
CI feedbackpassing · Nothing to fix: every check in this commit concluded successfully. |
CI feedbackfailing · 1. acceptance / specsWorkflow: acceptance (failure) First real error: 2. ciWorkflow: ci (failure) - rollup of the checks above First real error: Artifacts |
Pull request was closed
PR acceptance metricAcceptance rate: 88.5% — 440 merged / 497 decided PRs (3 still open, excluded from the denominator).
Generated by |
What
Re-pins every call of spiculedata/acceptance-spec (
run-specs.yml,base-check.ymlinacceptance.yml) from65c4575to380780e255019826deb3901987f4004a454a7659(main: includes #3waivable-paths, #4 base-cache fix). Docs updated (docs/acceptance-specs.md: pin, cache now works, why the gate is still local). That doc held the only stated pin; ci-overview / acceptance README / AGENTS.md name no SHA.The convention gate (
ci / acceptance convention) is deliberately NOT moved in this PR. It is built and proven on branchci/convention-shared(no PR opened), blocked on a one-line upstream input: spiculedata/acceptance-spec#5 (not merged).Why
convention.ymltake Saiku's exact waiver list, and a called job renders asci / acceptance conventionif the calling job is namedci(verified: that exact check name, and it is inside thecirollup and passes/fails it). Butci.ymlalso runs onpushandmerge_group, where the gate must not run. The only way today isif: github.event_name == 'pull_request'on the calling job, and a skipped calling job reports a bare check named after the caller job: here a skipped check namedci, the same name as the single required aggregate, measured on a push to aphase-*branch (ci | completed skippedappeared immediately beside the realci). I cannot prove the merge queue ignores it without merging, so I did not ship it. Distributed Cache #5 addsskip-outside-pull-request, so the called job skips itself and no bare check exists; measured on a push: onlyci / acceptance convention | skipped, no bareci.Compatibility
Enforced behaviour unchanged: the gate, its scripts and tests,
acceptance/2172are byte-identical todevelopment. Check names unchanged (acceptance / specsalias,acceptance / acceptance specs,detect changed specs,specs on head|base,spec fails on base,ci / acceptance convention).Semantics proven for the follow-up (done offline with the real scripts at the new pin, before the branch was split): over 2713 paths (every tracked file plus edge cases) the local waiver list and
waivable-paths(9 patterns;.mdwas case-insensitive, so\.[mM][dD]$) classify identically, 0 differences.saiku-core/e2e/x.jsandtest/x.javaare waivable in the old shared built-in list and NOT with Saiku's list. CLI outputs (cutoff 2181 / unset / no closing keyword / missing / waived / rejected) are identical except one cosmetic line: the closing hint now points at acceptance-spec'sdocs/spec-format.md. Cutoff staysvars.ACCEPTANCE_ENFORCE_FROM_ISSUE(with: enforce-from-issue: ${{ vars... }}works), sameacceptance-waivedlabel.Verification (GitHub; throwaway PRs #2250-#2255 closed, branches deleted, never merged; they ran the moved-gate branch state, stacked on this PR)
Cache not found for input keys: acceptance-base-v1-cc333abd...,specs on base10m 12s,Cache saved with key: acceptance-base-v1-cc333abd...-cbbd7480608aa6e6. Push 2:Cache hit for: acceptance-base-v1-cc333abd...,Cache restored from key,Build the BASE appandSave the base buildskipped,specs on base36 s.ci / acceptance conventionfailure (acceptance/999990/spec.json MISSING),cifailure.acceptance-waived,tests/file: convention success,cisuccess. THROWAWAY (do not merge): saiku-core/e2e not waivable #2252 (saiku-core/e2e/) and THROWAWAY (do not merge): test/ not waivable #2253 (test/) with the label: convention failure,cifailure.spec fails on basefailure:acceptance/999991/spec.json: passes on the base branch: it proves nothing about this change.spec fails on basesuccess:red on base, green on head.spec-already-greenon (c): not applied (human only). It would excuse that spec sospec fails on basepasses. Not exercised.ci,acceptance / acceptance specs,acceptance / specs,ci / acceptance conventionpass;node --test .github/scripts/*.test.mjs414 pass.Risk
Low: pin bump of the two workflows only. The hive watcher's
acceptance / specsalias is untouched.Not verified
ci(why the move waits). The Distributed Cache #5 fix was measured on a push only, not onmerge_group.not-runpath);spec-already-green.ci.ymlandacceptance.ymlonci/convention-sharedwith the merge commit, delete the local scripts as that branch does (acceptance/2172ported to assert the ci.yml wiring), merge.🤖 Generated with Claude Code