Skip to content

feat: skip-outside-pull-request input for convention.yml - #5

Merged
buggtb merged 1 commit into
mainfrom
feat/convention-skip-outside-pr
Oct 12, 2026
Merged

buggtb merged 1 commit into
mainfrom
feat/convention-skip-outside-pr

Conversation

@buggtb

@buggtb buggtb commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

What

New optional boolean input skip-outside-pull-request on convention.yml (default false). When true, the acceptance convention job is skipped (job-level if) on any event but pull_request instead of failing in its guard step. Default behaviour is unchanged.

Why

Found moving saiku's ci / acceptance convention onto this workflow (spiculedata/saiku#2249). saiku's ci.yml also runs on push and merge_group, where there is no PR body, so the call must not run there. The only way for a caller to do that today is if: github.event_name == 'pull_request' on the calling job. Measured on GitHub: a skipped calling job reports a bare check run named after the caller job. saiku renders the check name ci / acceptance convention by naming the caller job ci, which is also the name of its single required aggregate check, so on push / merge_group a SKIPPED check named ci appears beside the real one. Whether the merge queue could treat it as the required check was not provable without merging, so saiku does not ship that. With this input the calling job is never skipped and only the called job is, which reports as ci / acceptance convention skipped and creates no bare check.

Verification

  • node --test "scripts/*.test.mjs": 136 pass (new workflow guard).
  • Not yet exercised on GitHub from a caller on a push event; saiku will do that against this commit before re-pinning.

Risk

Low. Additive, default off, no new permissions or secrets.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Barber <tom@spicule.co.uk>
@github-actions

Copy link
Copy Markdown

Acceptance self-test (fixture)

Check Result What it means
Convention (a closing PR ships its spec) Nothing to check Nothing to check on this PR.
Specs on this PR's build Pass Everything that ran passed.
Spec-first proof (red on base, green on this PR) Nothing to check Nothing to check on this PR.

Updated for commit fe2d14c, workflow run. This comment is edited in place, never repeated.

@buggtb
buggtb merged commit aaf4586 into main Oct 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant