Repository navigation
feat: skip-outside-pull-request input for convention.yml - #5
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Acceptance self-test (fixture)
Updated for commit fe2d14c, workflow run. This comment is edited in place, never repeated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New optional boolean input
skip-outside-pull-requestonconvention.yml(default false). When true, theacceptance conventionjob is skipped (job-levelif) on any event butpull_requestinstead of failing in its guard step. Default behaviour is unchanged.Why
Found moving saiku's
ci / acceptance conventiononto this workflow (spiculedata/saiku#2249). saiku'sci.ymlalso runs onpushandmerge_group, where there is no PR body, so the call must not run there. The only way for a caller to do that today isif: github.event_name == 'pull_request'on the calling job. Measured on GitHub: a skipped calling job reports a bare check run named after the caller job. saiku renders the check nameci / acceptance conventionby naming the caller jobci, which is also the name of its single required aggregate check, so on push / merge_group a SKIPPED check namedciappears beside the real one. Whether the merge queue could treat it as the required check was not provable without merging, so saiku does not ship that. With this input the calling job is never skipped and only the called job is, which reports asci / acceptance conventionskipped and creates no bare check.Verification
node --test "scripts/*.test.mjs": 136 pass (new workflow guard).Risk
Low. Additive, default off, no new permissions or secrets.
🤖 Generated with Claude Code