Repository navigation
ci: call the shared acceptance-spec workflows for specs and spec-first proof - #2243
Merged
Merged
Conversation
…first proof acceptance.yml becomes two thin callers of spiculedata/acceptance-spec (run-specs.yml and base-check.yml) pinned to a full commit SHA, in mode: enforce. Saiku keeps only what is its own: the Maven build of the launcher with the GitHub Packages token, the loopback FoodMart demo start, the REST paths and the admin/admin demo login. The caller jobs are named `acceptance` so the called jobs keep the names `acceptance / detect changed specs`, `acceptance / specs on base` and `acceptance / spec fails on base`; a small `specs` job republishes the result as `acceptance / specs`, which the hive label watcher keys on. Removes the duplicated acceptance-base-check.mjs and its test (the shared copy carries the same cases) and adds acceptance-caller.test.mjs to guard the pin, the enforcing mode, the check names and the trust model. The convention gate (`ci / acceptance convention`) and the local acceptance-check/runner/spec scripts stay: see docs/acceptance-specs.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Semantic model diffNo semantic model changed in this pull request, so there was nothing to diff. |
…t a pinned SHA acceptance-specs.md gains "What is still local" (the convention gate and its scripts, and why) and "Bumping acceptance-spec"; ci-overview.md, acceptance/ README.md, AGENTS.md, review-rubric.md and ci-feedback.md point at them and list the check names, the CI credential names (ACCEPTANCE_USER/PASSWORD) and the dropped manual deployed run. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
CI feedbackpassing · Nothing to fix: every check in this commit concluded successfully. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Upstream builds base/./acceptance-launcher.jar, which actions/cache rejects (spiculedata/acceptance-spec#4 fixes it). The setting stays so the cache starts working on the next re-pin. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
buggtb
marked this pull request as ready for review
October 12, 2026 04:06
PR acceptance metricAcceptance rate: 89.8% — 447 merged / 498 decided PRs (2 still open, excluded from the denominator).
Generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
acceptance.ymlstops carrying its own copies of the spec runner workflow and the spec-first proof. It becomes two thin callers of the reusable workflows in spiculedata/acceptance-spec (run-specs.yml,base-check.yml), pinned to the full SHA65c4575aa9f7b7f64874c90a106db7f8456663e5, inmode: enforce. What stays here is what is Saiku's: the Maven build of the launcher with the GitHub Packages token, the loopback FoodMart demo start, the REST paths, the admin/admin demo login.Also: deletes
acceptance-base-check.mjsand its test (the shared copy has the same cases), addsacceptance-caller.test.mjs(guards the pin, enforce mode, check names, trust model), and updatesdocs/acceptance-specs.md,docs/ci-overview.md,acceptance/README.md,AGENTS.md,docs/review-rubric.md,docs/ci-feedback.md(logic lives upstream at a pinned SHA; "Bumping acceptance-spec"; "What is still local").Deliberately NOT migrated: the
ci / acceptance conventionjob and the localacceptance-check/runner/specscripts. See gap 1 and 2 below.Why
One copy of the logic instead of two, with Saiku's enforced behaviour unchanged. Where the shared workflows could not reproduce something Saiku enforces, I did not ship a regression: that part stays local and the missing capability is a separate upstream PR.
Compatibility analysis
Check names (a called job reads
<caller job name> / <called job name>; every caller job here is namedacceptance):ci / acceptance conventioncirollupacceptance / detect changed specsacceptance / specs on baseacceptance / spec fails on baseacceptance / specsEXTRA_CHECKSinquality-queue/label-watch.sh, exactcheck_name)name: acceptance / specs,needs: run-specs, red unless run-specs succeeded). The called job is namedacceptance specsupstream, so it appears as the NEWacceptance / acceptance specs; no caller job id can produceacceptance / specsacceptance / acceptance specsacceptance / specs on headNothing outside this repository was edited. Names that are new are additive; no existing name changed or vanished.
mode: enforce. Unchanged: neither is incior a ruleset (onlyciis required), so they report red but do not block, as before.vars.ACCEPTANCE_ENFORCE_FROM_ISSUE,acceptance-waived, insideci)session-path: /rest/saiku/session,base-path: /rest/saiku/api. Specs 818 and 2193 (session login, api) pass on head and base.ACCEPTANCE_USER/ACCEPTANCE_PASSWORD, passed as literalsadmin/adminundersecrets:(a reusable workflow can only take them that way). Side effect: GitHub masks the word "admin" in these logs. No existing spec uses{{env.SAIKU_*}}orSAIKU_BASE_URL(grepped), so none breaks; the docs now say not to.not-runBUILD_TOKEN: ${{ secrets.GH_PACKAGES_TOKEN }},skip-without-build-token: true, samesettings.xmland Maven command (written from$GITHUB_ACTOR/$BUILD_TOKENinsidebuild-command). Difference: on a fork, upstream skips the base build even when a cached base jar exists (before, a cache hit could still run api specs on a fork; head isnot-runthere anyway, so the verdict isnot-runeither way).base/./acceptance-launcher.jar, whichactions/cacherejects ("Relative pathing '.' and '..' is not allowed"); nothing is saved, so a re-push rebuilds the base (~9 min, parallel with head, so about the same wall clock, more runner minutes). Fix: spiculedata/acceptance-spec#4.base-cache-pathsis already set here and starts working on the next re-pin. Proven on a throwaway PR pointed at the fix: second pushCache hit for: acceptance-base-v1-...,Build the BASE app skipped,specs on base43 s (vs 10 m 3 s cold).acceptance-specs-<PR>,cancel-in-progress.node-version: "24", JDK 22 Temurin with Maven cache, as before.SAIKU_DEMO=true,SAIKU_TELEMETRY=off,-XX:+ExitOnOutOfMemoryError, loopback:18080), detached by upstream's script; readiness 300 s on/rest/saiku/info(upstream accepts any 2xx, before exactly 200). The fat JAR is copied toacceptance-launcher.jarso start and cache need no glob.ci-feedback.jsonintegrationacceptancekey into an artifactci-feedback.json. Nothing reads it:ci-feedback.ymlbuilds its own document from the API and never downloads PR artifacts (workflow header), and a grep of this repo and the hive tooling found no consumer. The local runner still has--feedback/attachand specacceptance/2172still asserts it. Results JSON is still uploaded; artifact names now carry the run id instead of the PR number.workflow_dispatchwithtarget: deployedpull_request. TheACCEPTANCE_BASE_URLvariable is now unused.pull_requestonly,contents: read, the only real secret isGH_PACKAGES_TOKEN; all actions SHA-pinned; scripts fetched at exactly the pinned SHA and verified (log:acceptance-spec scripts: spiculedata/acceptance-spec @ 65c4575...). Guard test added.acceptance specsand base-check'sspecs on head), 3 Maven builds instead of 2. Upstream's opt-inshare-buildavoids it but serialises base after head; not enabled.acceptance-base-check.mjs+ test: every logic test case exists in upstream'sacceptance-base-check.test.mjs(same names), the workflow-wiring tests are replaced byacceptance-caller.test.mjs. Keptacceptance-check.mjs,acceptance-runner.mjs,acceptance-spec.mjs+ tests: the gate needs the first and last (gap 1), andacceptance/2172/check.mjsimports all three and asserts local behaviour including ci-feedback.Verification
All on GitHub, SHA
b989e320and earlier commits of this PR; throwaway PRs #2245/#2246 are closed and their branches deleted, never merged.acceptance / acceptance specspass (2m21s, all 9 specs pass incl. api specs with session login),acceptance / specspass,acceptance / detect changed specspass,specs on head/specs on base/spec fails on baseskipped (as before),ci / acceptance conventionpass,ci / flake-policy testspass,cipass. Every check that passed ondevelopmentstill exists under the same name and passes.Closes #999990, no spec):ci / acceptance conventionfailure:acceptance convention: acceptance/999990/spec.json MISSING/this PR closes #999990 but adds no acceptance/999990/spec.json;cifailure.acceptance/999991, session-login api spec that works on base):acceptance / specs on basesuccess,specs on headsuccess,acceptance / spec fails on basefailure:acceptance/999991/spec.json: passes on the base branch: it proves nothing about this change....acceptance / spec fails on basesuccess:red on base, green on head;ci / acceptance conventionsuccess (it ships its spec).node --test .github/scripts/*.test.mjs414 pass;python3 -m unittestpass;acceptance/2172passes with the local scripts.Risk
Low for enforcement: nothing that gated a merge changed (
cirollup and the convention job untouched). Medium for naming:acceptance / specsnow exists only via the alias job; if the alias is removed the hive watcher silently goes blind to acceptance (it reads a missing check as pending). Known cost: extra head build on spec-changing PRs, and the base cache is off until the re-pin. Pin bumps are a one-line, two-place change (docs: "Bumping acceptance-spec").Unverified
GH_PACKAGES_TOKEN): thenot-runpath was not exercised on GitHub; only reasoned from upstream'sskip-without-build-tokenand its fixture tests.spec-already-greenlabel excusing a base-green spec was not exercised end to end (script cases are tested upstream).convention.ymlwith Saiku'swaivable-pathslist and confirm the base cache hit.hive/RUNBOOK.mdline 165 still saysacceptance / specsruns againstdemo.saiku.bi; it was already stale and is outside this repo (not edited).🤖 Generated with Claude Code