Repository navigation
feat: waivable-paths input for convention.yml - #3
Merged
Merged
Conversation
The acceptance-waived label holds only when every changed file is documentation or a test, judged against a built-in list. That list is deliberately generous (any e2e/ directory, a top-level test/), which is wider than a repository such as saiku, whose waiver covers only saiku-ui/e2e/ and tests/. Adopting convention.yml as it stands would therefore weaken saiku's enforced waiver. New optional input waivable-paths (env ACCEPTANCE_WAIVABLE_PATHS): newline separated regular expressions that replace the built-in list entirely. Blank lines and # comments are skipped; an expression that does not compile exits 2, never a silent waiver. Empty keeps today's behaviour, so existing callers are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Tom Barber <tom@spicule.co.uk>
Acceptance self-test (fixture)
Updated for commit da134fd, workflow run. This comment is edited in place, never repeated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New optional
waivable-pathsinput onconvention.yml(passed asACCEPTANCE_WAIVABLE_PATHS): newline-separated JavaScript regular expressions, matched against repository-relative paths, that replace the built-in docs-and-tests list for theacceptance-waivedlabel. Blank lines and#comments are skipped. An expression that does not compile makesacceptance-check.mjsexit 2 (never a silent waiver). Empty keeps today's behaviour.Why
Migrating spiculedata/saiku onto the shared workflows (spiculedata/saiku#2243) found one enforced behaviour the shared convention cannot express: saiku waives only
saiku-ui/e2e/andtests/, the built-in list waives any(^|/)e2e/andtests?/. With the built-in list, a PR putting product code under e.g.saiku-core/e2e/could takeacceptance-waived. saiku keeps its own convention gate until it can pass its exact list and re-pins.Verification
node --test "scripts/*.test.mjs": 129 pass (new: parsing, bad expression, list replaces built-ins, CLI env incl. exit 2, workflow guard).Risk
Low. Additive input, default empty. The expressions come from the caller's workflow file (same trust as
modeorbuild-command); a pathological expression could only slow the caller's own convention job (5 minute timeout).Not verified
🤖 Generated with Claude Code