Skip to content

feat: waivable-paths input for convention.yml - #3

Merged
buggtb merged 1 commit into
mainfrom
feat/waivable-paths-input
Oct 12, 2026
Merged

buggtb merged 1 commit into
mainfrom
feat/waivable-paths-input

Conversation

@buggtb

@buggtb buggtb commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

What

New optional waivable-paths input on convention.yml (passed as ACCEPTANCE_WAIVABLE_PATHS): newline-separated JavaScript regular expressions, matched against repository-relative paths, that replace the built-in docs-and-tests list for the acceptance-waived label. Blank lines and # comments are skipped. An expression that does not compile makes acceptance-check.mjs exit 2 (never a silent waiver). Empty keeps today's behaviour.

Why

Migrating spiculedata/saiku onto the shared workflows (spiculedata/saiku#2243) found one enforced behaviour the shared convention cannot express: saiku waives only saiku-ui/e2e/ and tests/, the built-in list waives any (^|/)e2e/ and tests?/. With the built-in list, a PR putting product code under e.g. saiku-core/e2e/ could take acceptance-waived. saiku keeps its own convention gate until it can pass its exact list and re-pins.

Verification

  • node --test "scripts/*.test.mjs": 129 pass (new: parsing, bad expression, list replaces built-ins, CLI env incl. exit 2, workflow guard).
  • Default behaviour unchanged (existing waiver tests untouched).

Risk

Low. Additive input, default empty. The expressions come from the caller's workflow file (same trust as mode or build-command); a pathological expression could only slow the caller's own convention job (5 minute timeout).

Not verified

  • Not run cross-repository from a caller yet; saiku will pass its list after this merges and it re-pins.

🤖 Generated with Claude Code

The acceptance-waived label holds only when every changed file is documentation
or a test, judged against a built-in list. That list is deliberately generous
(any e2e/ directory, a top-level test/), which is wider than a repository such as
saiku, whose waiver covers only saiku-ui/e2e/ and tests/. Adopting convention.yml
as it stands would therefore weaken saiku's enforced waiver.

New optional input waivable-paths (env ACCEPTANCE_WAIVABLE_PATHS): newline
separated regular expressions that replace the built-in list entirely. Blank
lines and # comments are skipped; an expression that does not compile exits 2,
never a silent waiver. Empty keeps today's behaviour, so existing callers are
unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Barber <tom@spicule.co.uk>
@github-actions

Copy link
Copy Markdown

Acceptance self-test (fixture)

Check Result What it means
Convention (a closing PR ships its spec) Nothing to check Nothing to check on this PR.
Specs on this PR's build Pass Everything that ran passed.
Spec-first proof (red on base, green on this PR) Nothing to check Nothing to check on this PR.

Updated for commit da134fd, workflow run. This comment is edited in place, never repeated.

@buggtb
buggtb merged commit ec8410e into main Oct 12, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant