Skip to content

chore(skill): add Drawer and Dialog accessibility rules to frontend skill #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alx-xo merged 1 commit into from
May 20, 2026
Merged

chore(skill): add Drawer and Dialog accessibility rules to frontend skill #2937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .agents/skills/frontend/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,45 @@ Grep `stage="preview"` and `stage="beta"` and delete every match:
- Inline `<ReleaseStageBadge>` usages — delete the element and unwrap the `flex items-center gap-2` div

There's no other cleanup. The component itself stays in place for the next pre-GA feature.

### Drawer Component Usage

`DrawerContent` requires `DrawerTitle` (and optionally `DrawerDescription`) inside it. Omitting them generates a console error and breaks screen reader accessibility. `DrawerHeader` and `DrawerFooter` are optional layout wrappers.

```tsx
<Drawer>
<DrawerTrigger>Open</DrawerTrigger>
<DrawerContent>
<DrawerTitle>Session Details</DrawerTitle>
<DrawerDescription>Viewing trace for this chat.</DrawerDescription>
{/* content */}
</DrawerContent>
</Drawer>
```

If the title is visually redundant, hide it from sighted users while keeping it for screen readers:

```tsx
<DrawerTitle className="sr-only">Details</DrawerTitle>
```

### Dialog Component Usage

`DialogContent` requires `DialogTitle` (and optionally `DialogDescription`) inside it. Omitting them generates a console error and breaks screen reader accessibility. `DialogHeader` and `DialogFooter` are optional layout wrappers.

```tsx
<Dialog>
<DialogTrigger>Open</DialogTrigger>
<DialogContent>
<DialogTitle>Confirm Action</DialogTitle>
<DialogDescription>This cannot be undone.</DialogDescription>
{/* content */}
</DialogContent>
</Dialog>
```

If the title is visually redundant, hide it from sighted users while keeping it for screen readers:

```tsx
<DialogTitle className="sr-only">Details</DialogTitle>
```
Loading