chore(skill): add Drawer and Dialog accessibility rules to frontend skill#2937
Conversation
DrawerTitle/DialogTitle are required inside DrawerContent/DialogContent to avoid console errors and satisfy screen reader requirements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
2 participants
Summary
DrawerContentrequiresDrawerTitle(and optionallyDrawerDescription) to avoid console errors and satisfy screen reader accessibilityDialogContent→DialogTitlesr-onlyescape hatch for visually redundant titlesRoot cause
Missing
DrawerTitle/DialogTitlegenerates a console warning (DialogContent requires a DialogTitle for the component to be accessible for screen reader users) and breaks accessibility. This was not documented in the frontend skill, making it easy to miss when adding new drawers or dialogs. As this is an accessibility error it does not break anything but does generate error noise in console and DataDogRecently fixed a bug about this here and adding to frontend skill to prevent this in future. #2929
Test plan
DrawerContent/DialogContentusages in the dashboard — 0 violations foundChatDetailPanel(the mainDrawerContentconsumer) rendersDrawerTitlein all branches (loading, not-found, populated)