Skip test_snmp_queue_counter on C0 topo#25946
Merged
Merged
Conversation
Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
Collaborator
|
/azp run |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
lizhijianrd
added
Created PR to msft-202603 branch
and removed
Cherry Pick Conflict_msft-202603
labels
12 tasks
lizhijianrd
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jul 7, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md --> ### Description of PR Cherry-pick of upstream [sonic-net/sonic-mgmt#25946](sonic-net/sonic-mgmt#25946) to `202603`. Summary: Skip `tests/snmp/test_snmp_queue_counters.py` on `c0` topo. This feature is not required on C0. ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 Tracking issue/work item for backport/cherry-pick request: N/A Failure type: N/A ### Approach #### What is the motivation for this PR? `test_snmp_queue_counters.py` is not a required feature on C0 topology. Add `c0` to the `topo_type` skip list in `tests_mark_conditions.yaml`. #### How did you do it? Extended the existing skip condition for `snmp/test_snmp_queue_counters.py`: - `topo_type in ['m0', 'mx', 'm1']` → `topo_type in ['m0', 'mx', 'm1', 'c0']` - Updated the accompanying `reason` string to mention C0. #### How did you verify/test it? Change is confined to conditional-mark yaml; no runtime code change. The upstream PR was merged to `sonic-net/sonic-mgmt:master` after review. #### Any platform specific information? None — topology-based skip. #### Supported testbed topology if it's a new test case? N/A (existing test). ### Cherry-pick notes Upstream cherry-pick to `msft-202603` conflicted (label `Cherry Pick Conflict_msft-202603` was applied on the upstream PR). Root cause: `master` already contains an unrelated Mellanox `#17929` skip condition for the same test that hasn't been ported to `202603`. This cherry-pick keeps only the PR 25946 intent (adding `c0` to the skip list) and does **not** pull in the unrelated Mellanox condition. Original commit: `707d11172fc79c58ffb72d0beec83afa02bbaae0` ### Documentation N/A. Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
lizhijianrd
added
Included in msft-202603 branch
and removed
Created PR to msft-202603 branch
labels
zypgithub
pushed a commit
to zypgithub/sonic-mgmt
that referenced
this pull request
Jul 8, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Skip test_snmp_queue_counter on C0 topo. This is not a required feature on C0. <!-- If you request a backport/cherry-pick below, link the GitHub issue or ADO work item here (for example, "Fixes #<issue>" or "ADO: <work item URL>"). --> ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [x] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request <!-- Only check a release or feature branch when the PR links a GitHub issue or ADO work item above. The linked tracker should explain the failure in detail, including whether it is a day-one issue or a regression, the affected branch/image/platform/test, and why this branch needs the fix. Backport or cherry-pick requests without a linked issue/work item may not be favored. --> - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [x] 202605 Tracking issue/work item for backport/cherry-pick request: Failure type: <!-- day-one issue / regression / other --> ### Approach #### What is the motivation for this PR? Skip test_snmp_queue_counter on C0 topo. This is not a required feature on C0. #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Skip test_snmp_queue_counter on C0 topo. This is not a required feature on C0.
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request:
Failure type:
Approach
What is the motivation for this PR?
Skip test_snmp_queue_counter on C0 topo. This is not a required feature on C0.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation