[action] [PR:25946] Skip test_snmp_queue_counter on C0 topo#1290
Merged
Conversation
Signed-off-by: Zhijian Li <zhijianli@microsoft.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick of upstream sonic-net/sonic-mgmt#25946 to
202603.Summary: Skip
tests/snmp/test_snmp_queue_counters.pyonc0topo. This feature is not required on C0.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request: N/A
Failure type: N/A
Approach
What is the motivation for this PR?
test_snmp_queue_counters.pyis not a required feature on C0 topology. Addc0to thetopo_typeskip list intests_mark_conditions.yaml.How did you do it?
Extended the existing skip condition for
snmp/test_snmp_queue_counters.py:topo_type in ['m0', 'mx', 'm1']→topo_type in ['m0', 'mx', 'm1', 'c0']reasonstring to mention C0.How did you verify/test it?
Change is confined to conditional-mark yaml; no runtime code change. The upstream PR was merged to
sonic-net/sonic-mgmt:masterafter review.Any platform specific information?
None — topology-based skip.
Supported testbed topology if it's a new test case?
N/A (existing test).
Cherry-pick notes
Upstream cherry-pick to
msft-202603conflicted (labelCherry Pick Conflict_msft-202603was applied on the upstream PR). Root cause:masteralready contains an unrelated Mellanox#17929skip condition for the same test that hasn't been ported to202603. This cherry-pick keeps only the PR 25946 intent (addingc0to the skip list) and does not pull in the unrelated Mellanox condition.Original commit:
707d11172fc79c58ffb72d0beec83afa02bbaae0Documentation
N/A.