Repository navigation
Conversation
The test suite runs against the raw source tree, where skk-autoloads.el does not exist, so autoloaded functions are void unless their defining file is explicitly required. In particular, skk-tankan-test.el failed because `skk-today' (bound to "@" and defined in skk-gadget.el) was void: `skk-kana-input' silently drops the key when the rule function is not fboundp, so "@" never reached the henkan key and tankan conversion did not trigger. Give every test file the same require list, including skk-gadget, so each of them can also be run standalone.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skk-autoloads.elが無い状態でmake testをすると、テストの実行に失敗するのを修正します。具体的には
skk-tankan-test.elを実行する際、skk-todayがvoidとなるため@が入力されず、単漢変換のテストに失敗します。また、テストファイル単体をロードして実行した場合、
skk-cus等がロードされないためエラーとなります。これらの問題を修正するために各テストファイルで各ファイルを明示的にrequireします。