Repository navigation
Conversation
skk-dev#229 When a word is registered with `skk-force-registration-mode-char`, a wrong entry is registered to the dictionary. This patch adjusts `skk-henkan-count` when the user enter non-empty string, so that it points to the new word.
taku0
marked this pull request as draft
July 29, 2026 15:38
Contributor
Author
|
Emacs 28以前で上手く動いてないようなので確認します。 |
We must do `(setq list (sort list))` for Emacs 28 and earlier.
taku0
marked this pull request as ready for review
July 30, 2026 11:54
Contributor
Author
|
Emacs 28以前でテストが通らない問題を解決しました。テスト用のユーティリティ関数の問題で、同じ原因でスキップしていたテストも通るようになりました。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#229 を修正します。
ユーザが空でない文字列を辞書登録用にミニバッファで入力した場合、
skk-henkan-countが新しく追加された単語を指すようにします。skk-henkan-show-candidates内で.の入力を処理する際にskk-henkan-countを調整する案も考えたのですが、再帰的に辞書登録するときなどの挙動が読み切れなかったため、確実な方法(ユーザが空でない文字列を辞書登録用にミニバッファで入力した時点で設定する)としました。