Skip to content

fix(remote-control-status): use a Nerd Fonts v3 codepoint for the off… #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
D-L-Narayana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(remote-control-status): use a Nerd Fonts v3 codepoint for the off… #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/widgets/RemoteControlStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ import {

const SATELLITE_EMOJI = '📡';
const SATELLITE_NERD_FONT = '';
const SATELLITE_SLASH_NERD_FONT = '';
// nf-md-wifi_off. Nerd Fonts v3 moved the Material Design icons out of the
// BMP; the v2 codepoint this used to be (U+F6AC) is unassigned in v3 fonts.
const SATELLITE_SLASH_NERD_FONT = '\u{f05aa}';
const STATE_DOT_OFF = '○';
const STATE_DOT_ON = '◉';

Expand Down
6 changes: 3 additions & 3 deletions src/widgets/__tests__/RemoteControlStatus.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ describe('RemoteControlStatusWidget', () => {
describe('render() - format icon, Nerd Font', () => {
const NERD_ITEM: WidgetItem = { ...ITEM, metadata: { nerdFont: 'true' } };

it('renders disconnected glyph (U+F6AC) when OFF', () => {
it('renders nf-md-wifi_off (U+F05AA) when OFF', () => {
vi.spyOn(claudeSettings, 'getRemoteControlStatus').mockReturnValue({ enabled: false });
expect(new RemoteControlStatusWidget().render(NERD_ITEM, makeContext(), DEFAULT_SETTINGS)).toBe('\uF6AC');
expect(new RemoteControlStatusWidget().render(NERD_ITEM, makeContext(), DEFAULT_SETTINGS)).toBe('\u{F05AA}');
});

it('renders connected glyph (U+F1EB) when ON', () => {
Expand Down Expand Up @@ -317,7 +317,7 @@ describe('RemoteControlStatusWidget', () => {
{
name: 'icon with Nerd Font',
item: { ...RAW_ITEM, metadata: { nerdFont: 'true' } },
off: '\uF6AC',
off: '\u{F05AA}',
on: '\uF1EB'
},
{
Expand Down