Repository navigation
fix(remote-control-status): use a Nerd Fonts v3 codepoint for the off… - #605
Open
D-L-Narayana wants to merge 1 commit into
Open
D-L-Narayana wants to merge 1 commit into
D-L-Narayana wants to merge 1 commit into
Conversation
… icon The Nerd Font "off" glyph was U+F6AC, a Nerd Fonts v2 codepoint from the Material Design range that v3 moved to the supplementary plane. Every v3 font renders it as a missing-glyph box, so `remote-control-status` showed tofu whenever remote control was off while the "on" icon (nf-fa-wifi, U+F1EB) rendered fine. Use nf-md-wifi_off (U+F05AA), the v3 location of the same icon and the natural pair for nf-fa-wifi. Checked against glyphnames.json from Nerd Fonts 3.5.1: U+F05AA is md-wifi_off and U+F6AC has no glyph. Fixes sirmalloc#597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… icon
The Nerd Font "off" glyph was U+F6AC, a Nerd Fonts v2 codepoint from the Material Design range that v3 moved to the supplementary plane. Every v3 font renders it as a missing-glyph box, so
remote-control-statusshowed tofu whenever remote control was off while the "on" icon (nf-fa-wifi, U+F1EB) rendered fine.Use nf-md-wifi_off (U+F05AA), the v3 location of the same icon and the natural pair for nf-fa-wifi. Checked against glyphnames.json from Nerd Fonts 3.5.1: U+F05AA is md-wifi_off and U+F6AC has no glyph.
Fixes #597