fix(sign): reject ALL and UNDEFINED service requirements it cannot meet - #235
Merged
Merged
Conversation
The signer submits to one Rekor log and one TSA. It already rejected EXACT with a count other than 1, but treated ALL like ANY and accepted UNDEFINED. Accept ALL only when every eligible endpoint belongs to one operator, and reject UNDEFINED and future selectors. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
baszalmstra
approved these changes
Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #231, as noted there. The signer submits to one Rekor log and one TSA. It already rejected
EXACTwith a count other than 1 (#218), but treatedALLlikeANYand acceptedUNDEFINED.ALLis accepted only when every eligible endpoint (supported version, valid now) belongs to a single operator. In that case one submission satisfies it; otherwise it's a config errorUNDEFINEDand future (#[non_exhaustive]) selectors are rejected instead of guessedANY, so their behaviour is unchangedValidation
cargo clippy -p sigstore-sign --all-targets --all-features -- -D warningscargo test -p sigstore-sign --all-features --lib(new test:ALLwith one operator passes;ALLacross two operators andUNDEFINEDfail, for both Rekor and TSA)Signed-off-by: Wolf Vollprecht w.vollprecht@gmail.com
🤖 Generated with Claude Code