refactor(rekor)!: remove built-in log URLs and fix stale docs - #240
Merged
Merged
Conversation
Follow-up to the #176 review: callers should see the log URL they use. `RekorApiVersion::default_url()` always pointed at production, which caused the #227 redirect, and the v2 URL names a shard that will be retired. Remove `RekorApiVersion::default_url` and `default_staging_url`, `RekorClient::public` and `staging`, and `get_public_log_info`. The examples now pass the URL explicitly. Also fix the docs flagged in the #193 review: `RekorApiVersion` no longer embeds dated URLs, `LogEntry::integrated_time` no longer refers to a removed V2 conversion, `to_bundle_entry` states which bounds it checks, and `RekorInclusionProof` no longer claims to hold raw strings. BREAKING CHANGE: `RekorApiVersion::default_url`, `RekorApiVersion::default_staging_url`, `RekorClient::public`, `RekorClient::staging` and `get_public_log_info` are removed; pass the log URL (for example from the instance's signing config) to `RekorClient::new`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
baszalmstra
approved these changes
Sep 24, 2026
This was referenced Sep 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.0 API work, PR R-b in the plan.
following Jussi's review on feat: complete and harden Rekor v2 support #176, remove the built-in log URLs, so callers see the URL they use:
RekorApiVersion::default_urlanddefault_staging_urlRekorClient::publicandstagingget_public_log_infodefault_url()always pointed at production (it caused the redirect fixed in fix(sign)!: keep the configured instance when selecting a Rekor version #227), and the v2 URL names a log shard that will be retiredfix the docs flagged in the refactor(types)!: deserialize semantic bundle values eagerly #193 review:
RekorApiVersionno longer embeds dated URLsLogEntry::integrated_timeno longer mentions a V2 conversion that doesn't existto_bundle_entrysays exactly which bounds it checksRekorInclusionProofno longer claims to hold raw stringsthe lib docs and README now call
RekorClient::new("https://rekor.sigstore.dev")sigstore-sign'sSigningConfig::default()still hardcodes the public-good Rekor URL. It already hardcodes Fulcio and the TSA too, and removing all of them is part of the signing-context PR (S-a).#[non_exhaustive]onRekorApiVersionis left for R-a, to avoid conflicting with #235.Validation
cargo clippy --workspace --all-targets --all-features -- -D warningscargo test -p sigstore-rekor -p sigstore-sign --all-features(including doctests)cargo check -p sigstore-rekor --no-default-featuresSigned-off-by: Wolf Vollprecht w.vollprecht@gmail.com
🤖 Generated with Claude Code