Use data column batch verification consistently - #6851
Merged
Merged
Conversation
dapplion
added
ready-for-review
jimmygchen
reviewed
Jan 30, 2025
jimmygchen
reviewed
Jan 30, 2025
jimmygchen
added
waiting-on-author
dapplion
added
ready-for-review
jimmygchen
added
ready-for-merge
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolve a
TODO(das)to use KZG batch verification input_rpc_custody_columnsProposed Changes
Uses
verify_kzg_for_data_column_list_with_scoringin all paths that send more than one column. To use batch verification and have attributability of which peer is sending a bad column.Needs to move
verify_kzg_for_data_column_list_with_scoringinto the type's module to convert to the KZG verified type.