Skip to content

feat: bypass reviews for deployment automation - #2

Merged
glitchedmob merged 3 commits into
mainfrom
feat/automation-review-bypass
Aug 21, 2026
Merged

feat: bypass reviews for deployment automation#2
glitchedmob merged 3 commits into
mainfrom
feat/automation-review-bypass

Conversation

@glitchedmob

Copy link
Copy Markdown
Member

Splits review enforcement from baseline branch protection so deployment automation can merge staging promotions without human approval.

  • Adds reusable review-only bypass actors to the repository module
  • Grants the deployment automation GitHub App pull-request bypass access for infra-k8s-apps
  • Keeps required Kubernetes checks, conversation resolution, and other branch protections non-bypassable
  • Orders ruleset updates so approval enforcement remains active during apply

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Terraform plan

Artifacts: https://github.com/sgfdevs/infra-gh/actions/runs/32440714053

Show summary
CHANGE RESOURCE
add (1) module.infrastructure_repository["infra-k8s-apps"].github_repository_ruleset.required_reviews[0]
update (2) module.board_team.github_team_membership.this["jenn8421"]
module.infrastructure_repository["infra-k8s-apps"].github_repository_ruleset.main

Decrypt artifacts:
openssl enc -d -aes-256-cbc -pbkdf2 -in tfplan.enc -out tfplan -pass pass:$OUTPUT_ENCRYPTION_KEY
openssl enc -d -aes-256-cbc -pbkdf2 -in tfplan.txt.enc -out tfplan.txt -pass pass:$OUTPUT_ENCRYPTION_KEY

@glitchedmob
glitchedmob merged commit 07404c0 into main Aug 21, 2026
10 checks passed
@glitchedmob
glitchedmob deleted the feat/automation-review-bypass branch August 21, 2026 02:50
glitchedmob added a commit that referenced this pull request Aug 21, 2026
The review ruleset introduced in #2 did not inherit the repository teams
already configured for ruleset bypass. This adds those teams to the
review-only ruleset with their existing `always` bypass mode while
retaining the deployment App’s pull-request-only bypass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant