Verify reproducibility fixture - #34
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00cf711c25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a real regression check for the bundled short reproducibility fixture.
Changed
examples/reproducible_case1_short/README.mdexamples/reproducible_case1_short/expected_tree.txtexamples/reproducible_case1_short/regenerate.pytests/test_reproducible_example.pyexpected_tree.txt;expected_summary.json;Why
The repository already ships a short reproducibility fixture under
examples/reproducible_case1_short/, but that fixture was not being checked by the test suite.This PR turns it into an executable regression test while avoiding brittle cross-machine failures from BLAS/NumPy/SciPy floating-point differences.
It also fixes the expected output tree so the documented command includes the final partial variable-history block.
Validation
python -m py_compile examples/reproducible_case1_short/regenerate.py tests/test_reproducible_example.py python -m pytest tests/test_reproducible_example.py python -m pytest python -m run_ldsfl --base-dir . --cases 1 --max-steps 100 --no-plotsNotes
This is a fixture/test/documentation PR.
It does not change the morphodynamic update algorithm, flow solvers, curvature calculation, stability diagnostics, CLI interface, GUI interface, or output naming.
The floating-point comparison is intentionally guarded by
environment.jsonso the test remains useful on CI and on local machines with different scientific-Python stacks.