Fix reproducibility fixture regeneration - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the reproducibility-fixture regeneration helper added in PR #34.
Changed
examples/reproducible_case1_short/regenerate.pyOutput/directory;expected_summary.jsonautomatically;expected_tree.txt,environment.json, andexpected_output/together.tests/test_reproducible_example.pyexamples/reproducible_case1_short/expected_output/expected_tree.txt.Why
Codex correctly flagged two issues in PR #34:
regenerate.pyremoved the whole repository-levelOutput/directory, which could wipe unrelated local experiment results.expected_tree.txtreferenced the finalvar_*_6.csvfile, but that file was not actually tracked in the bundled fixture output tree.This PR fixes both issues and also makes regeneration safer by refreshing the pinned summary at the same time as the output tree.
Validation
python -m py_compile examples/reproducible_case1_short/regenerate.py tests/test_reproducible_example.py python -m pytest tests/test_reproducible_example.py python -m pytest python -m run_ldsfl --base-dir . --cases 1 --max-steps 100 --no-plots