This repository was archived by the owner on May 6, 2020. It is now read-only.
Conversation
rust-lang/rust@9108fb7 dropped some old methods -- adapt the code accordingly. These changes should actually be backwards-compatible I think...
Changed upstream in rust-lang/rust@b32d7b5 This one is definitely not backwards-compatible -- so we have to depend on a newer syntex for this.
The last change updated version requirements of the dependencies. The interface we export to users might also have changed -- though I haven't really checked that... Either way, updating our version is in order.
Author
|
I hope I got the versioning right -- apparently Cargo doesn't let me test updated dependencies until the new versions are actually officially published :-( (Didn't want to sit on the otherwise finished PR though, especially since there are two more in the dependency chain...) The CI failure is also expected here, until the new version of syntex gets published... |
Author
|
Oh, I forgot to mention that this should fix #76 properly. |
This was referenced May 2, 2016
|
I just merged another PR that also fixed this, but thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to the changed interfaces, and bump the version number.
This builds on the updated
syntexfrom serde-deprecated/syntex#44 , so it works on stable Rust too.