Update for latest libsyntax changes - #303
Merged
Merged
Conversation
rust-lang/rust@9108fb7 dropped the `map()` method (among other things) -- so we need to adapt our code. This change should be backwards-compatible.
This was renamed upstream in rust-lang/rust@6c44bea It's an incompatible change requiring new versions of syntex, aster, and quasi.
Dependencies were updated in previous commit. (For supporting current Nightly Rust.) I guess this shouldn't affect our client interface -- which is why these dependency bumps only get patch level version number updates for Serde, I presume?
Contributor
Author
|
And finally, this one depends on serde-deprecated/aster#78 , serde-deprecated/syntex#44 , as well as serde-deprecated/quasi#41 |
|
Does this build now? |
Member
Member
|
@dtolnay: I've merged this in. Hopefully it'll pass travis now. |
Member
|
Looks like it passed! Let's cut a release to unblock everybody. |
Member
|
@dtolnay: 0.7.4 has (finally) been released! Thanks so much for all your work getting this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is mostly about updating dependencies on syntex, aster, and quasi -- along with a small code patch for adapting to the actual interface changes.