Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Fixes for issue #76 - #77

Merged
erickt merged 1 commit into
serde-deprecated:masterfrom
fabricedesre:rustup
May 3, 2016
Merged

erickt merged 1 commit into
serde-deprecated:masterfrom
fabricedesre:rustup

Conversation

@fabricedesre

Copy link
Copy Markdown

Fixes #76

@fabricedesre

Copy link
Copy Markdown
Author

Tests are passing locally.
r? @erickt

@fabricedesre

Copy link
Copy Markdown
Author

Oh, I guess we need to bump the version number...

@fabricedesre

Copy link
Copy Markdown
Author

ouch... wtf

@fabricedesre

Copy link
Copy Markdown
Author

Ok, I can reproduce when running |cargo build --features with-syntex|

@KodrAus

KodrAus commented Apr 28, 2016

Copy link
Copy Markdown

I think syntex will need to be updated too with the changes made to libsyntax, right?

@fabricedesre

Copy link
Copy Markdown
Author

I think syntex will need to be updated too with the changes made to libsyntax, right?

Yes, I started doing that in serde-deprecated/syntex#43
No idea so far why println!() ends up being broken...

@KodrAus

KodrAus commented May 2, 2016

Copy link
Copy Markdown

@fabricedesre Any update on this? Is there anything else we need to do?

@fabricedesre

Copy link
Copy Markdown
Author

@KodrAus I haven't fixed the test failure yet. Any help appreciated!

@KodrAus

KodrAus commented May 2, 2016

Copy link
Copy Markdown

Hmm, that println! error is really weird... Almost like it's not linking std? What's the point of that hello_world program?

@erickt
erickt merged commit 0ba5657 into serde-deprecated:master May 3, 2016
@erickt

erickt commented May 3, 2016

Copy link
Copy Markdown

Thanks! I'll fix up the issues on my side.

@fabricedesre

Copy link
Copy Markdown
Author

\o/ Thanks @erickt !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants