Repository navigation
Fix shader-tool lint and stale shader test fixtures - #2111
Closed
thehobbit85 wants to merge 1 commit into
Closed
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
This was referenced Nov 10, 2026
Contributor
Author
|
Closing as superseded by current main ( The hmma_bslots local rename is already in dmsh_rewrite.py; the entry-point fixtures now import the production dmsh_entry module, which supplies dmsh_fetch (80fc2ec and c398ff3). Fixed-offset uniform handling in e45694b also makes this PR’s guarded Pokopia expressions obsolete. Fresh checks on the main-identical shader sources passed 145 tests with one optional GPU skip; pinned Python lint has 321/321 findings, zero new or stale. No source or assertion change is needed. The PR branch is preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current main fails Python lint because
hmma_bslotsusesdepthfor both a parenthesis counter and its later lexical-depth helper. Rename only the counter, restoring the pinned lint ratchet to 336 existing findings with no new or stale entries. The production AST is otherwise identical.Restore the real
dmsh_fetchdependency in the extracted integer-output test fixture and update three Pokopia assertions for the translator's bounded uniform reads. The assertions still require the exact c3 words, binding-length guard, zero fallback, halfword shift, OR and selected half. No runtime workaround, suppression, skipped test or baseline increase is included.dmsh_build.pyis part of the shader chain, so the required header is regenerated toe82ac5d18f5e. Existing shader libraries need the normal rebuild for the new chain identifier even though this rename does not change shader output. The separate ABI-ratchet and C-lint issues already have #1981 and #2080; this PR does not duplicate them.Validation on Apple Silicon macOS 26.6, Xcode 27.2, Python 3.14.6, Ruff 0.17.2 and Pyright 1.1.414, against main
6d9edb079b2edfa5e8a85753b1740ef4275b383a:dm/tools/lint_python.pyreports 336 baseline findings, zero new and zero stale.test_dmsh_hmma,test_dmsh_meshstage,test_dmsh_ampere_memandtest_nsp_chain, with the pinned offline translator enabled. This includes local Metal/GPU, Mac/iOS shader compilation and chain metadata checks.A full per-game shader rebuild and gameplay comparison were not available:
regress.py check --gamesexits 2 becauseREGRESS_ROOTandREGRESS_GAMESare not configured. The intended focused games were Donkey Kong Bananza (HMMA), Pokemon Pokopia (halfword operations), Mario Kart World (integer stage outputs), and Yoshi and the Mysterious Book (guarded Ampere reads). No game, device, performance, complete graphics-suite or all-CI-green claim is made. No game data or agent artifacts are included.