Repository navigation
Return stored NVN sampler builder query state - #2115
Open
thehobbit85 wants to merge 1 commit into
Open
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Addresses the sampler-builder query failure reported in issue #872. The five queried properties already have setters and stored state, but their getters still reached the generic unimplemented handler. Comparison and border-colour outputs remained untouched; scalar getters did not supply the required float/enum results.
Implement
GetLodBias,GetCompare,GetBorderColor,GetMaxAnisotropyandGetReductionFilterusing each builder's current parameters. The regression invokes the exported entry points through the same lookup and counting thunks games use. It checks changed values, a separate default builder, reset defaults and the four-float output boundary.This resolves that concrete API defect only. #872's archive extraction, rendering and intermittent iPhone freeze remain open. No game files or gameplay validation were available, so this PR does not close the issue.
Checked
Apple M2 Max, macOS26.6, Xcode27.2, native arm64 builds, Python3.14.6.
make -C dm/gfx/tests GAME=010015100B514000 check_t_nvnpasses all295.make -C dm/gfx/tests -j2 GAME=010015100B514000 run: PASS, including the final value-comparison test revision.make -C dm/host -j2 GAME=010015100B514000 dmhost: PASS.nvn_mtl.m.IntegerPassThroughfixture errors (dmsh_fetchmissing from its extracted namespace).dmsh_build.py:166–167type findings. The preceding Python failures reproduce on a pristine export of base6c676444; the shared repair is already proposed in Fix shader-tool lint and stale shader test fixtures #2111.lint_c.py compdbsucceeds; changed-sourcetidy --against 6c676444 dm/gfx/nvn/hle_nvn.c dm/gfx/tests/t_nvn.chas no new findings. The full274-source run also reports an unrelatedt_pso_archive.mnullability count above its baseline; that reproduces on the pristine base with this toolchain.regress.py impact HEAD: five NVN entry points; three profiles reached only by the broad NVN rule,149 profiles have no usage manifest. Attemptedregress.py check --games 01004A4010FEA000,0100000000010000,010015100B514000,0100B04011742000,01007EF00011E000: exit2 because noREGRESS_ROOT/REGRESS_GAMESor game files are available. Bayonetta3 exercises builder readback, Odyssey caches sampler state, Wonder/Rise/Breath of the Wild broaden NVN renderer coverage. None was run; the reported title has no repository profile.Fresh main and all1467 open/draft/closed/merged PR descriptions plus the issue timeline were checked before publication: no existing solution for these getters.
Docs
docs/reference/nvn-objects.md; development docs updated; symptom index regenerated.