Repository navigation
test_dmsh_abi's ratchet no longer counts "?": the unknown binding kind is also what log lines write for a name they do not have, and the third such placeholder in nvn_mtl.m fails the Tool tests on main (issue #1656) - #1981
Closed
Atomsk-debug wants to merge 1 commit into
Closed
Atomsk-debug wants to merge 1 commit into
Atomsk-debug wants to merge 1 commit into
Conversation
…d is also what log lines write for a name they do not have, and the third such placeholder in nvn_mtl.m failed the Tool tests on main (issue seedds#1656) The ratchet counts the ABI's kind names and distinctive numbers written as literals in the files that use the header, so that they do not come back in place of the DMSH_* names. The unknown kind is "?", and nvn_mtl.m also writes "?" in log lines for a shader key, a module name or a pipeline description it does not have: two such placeholders were in the baseline, and the third (70b9a68, the pipeline archive index) made test_no_new_abi_literals fail on main, {'dm/gfx/nvn/nvn_mtl.m': {"'?'": '2 -> 3'}}, and with it the Tool tests job of every pull request. "?" is not distinctive enough to find as a literal, as 8, 16, 0x20 and 128 are not among the numbers: the ratchet now leaves the unknown kind out and the baseline no longer lists it. The other kinds and the numbers are counted as before. Checked: test_dmsh_abi (10 tests) fails on main and passes with the change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Atomsk-debug
force-pushed
the
abi-ratchet-placeholder
branch
from
November 9, 2026 18:56
2491d20 to
a9e772c
Compare
This was referenced Nov 10, 2026
Contributor
Author
|
Closing: main's 80fc2ec covers this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Tool tests job fails on main, and so on every pull request, in
dm/tools/tests/test_dmsh_abi.py:The ratchet counts the ABI's kind names and distinctive numbers written as literals in the files that use the header, so that they do not come back in place of the
DMSH_*names. The unknown kind is"?", andnvn_mtl.malso writes"?"in log lines for a shader key, a module name or a pipeline description it does not have: two such placeholders were in the baseline, and the third (70b9a68, the pipeline archive index,@"?"inakb_s) tripped it."?"is not distinctive enough to find as a literal, as 8, 16, 0x20 and 128 are not among the numbers: the ratchet now leaves the unknown kind out and the baseline no longer lists it. The other kinds and the numbers are counted as before. Part of #1656 (the Tool tests item; today's main has the other two items of that issue elsewhere:t_gfx_suspendlinks, and the iOS build'sIOBluetoothlink is #1899 / #1906).Checked
python3 -m unittest dm/tools/tests/test_dmsh_abi.pyfails on main (7974118) and passes with the change (10 tests). Every other tool, iOS and gfx test file of the CI loop passes locally on main (172 files).Docs
🤖 Generated with Claude Code