Repository navigation
lint-python is green again: the matching test's rule rewritings keep the cuts a list - #1374
Closed
oliverames wants to merge 1 commit into
Closed
oliverames wants to merge 1 commit into
oliverames wants to merge 1 commit into
Conversation
Contributor
Author
|
The same three findings fail |
…the cuts a list dd6ce5b's tests assign through rule['cuts'][0] on a descriptor pyright resolves as a str, one above the baseline; the rule now carries a fresh tuple as a list and the ratchet's count drops 387 to 384. The matching tests run the same.
oliverames
force-pushed
the
fix-nso-pyright
branch
from
November 7, 2026 20:20
9e2199c to
a45fc93
Compare
Contributor
Author
|
Main's e9d1ef2 fixed the same lint-python failure from the other side ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
dd6ce5ba's tests indm/tools/tests/test_nso_match.pyassign throughrule['cuts'][0], which pyright resolves as a string from the descriptor's type, and the ratchet counts these above the baseline: 42062501408,3 new. A rule written as{**self.rule, 'cuts': [...]}keeps the cuts a list.Checked
python3 dm/tools/lint_python.py --against FETCH_HEAD: 384 findings, the baseline 384 to 387 (the three file/check pairs below it), 0 new, 0 fixed but still listed.python3 dm/tools/tests/test_nso_match.py: unchanged output. The same-check run before the change: 3 new.Front ends
None: no front end has to act on this.
Docs
docs/reference/<subsystem>.mdentry, andpython3 dm/tools/docs_symptoms.pywas run (the symptom index). Not applicable: a lint-only fix to a test and the lint baseline, with no game note or reference entry in the diff. The description says "Docs: none."dmsh_chain.py --headerwas run anddm/gfx/nvn/dmsh_chain.his part of the change. Not applicable: no chain tool changed.