Repository navigation
Tests check the Metal device, textures, encoders and functions they make before using them - #1338
Closed
oliverames wants to merge 1 commit into
Closed
oliverames wants to merge 1 commit into
oliverames wants to merge 1 commit into
Conversation
…ake before using them clang-tidy's nullability check flags t_int_float_view.m (introduced by f083873): it passes unchecked results of MTLCreateSystemDefaultDevice, newTextureWithDescriptor, newTextureViewWithPixelFormat and the command and encoder calls into later calls, so lint-c fails on main. Same fix as ad7af9c for the other Metal tests. No change to what the test checks.
github-actions
Bot
added
the
nvn
1 of 3 tasks
3 tasks done
Contributor
Author
|
Both this and the three pyright findings on main's own head block the rest of the open-PR fleet's checks: my rebases tonight re-ran them against 865cc35 and every run that touches |
1 of 3 tasks
2 of 3 tasks
seedds
added a commit
that referenced
this pull request
Nov 6, 2026
…ake before using them: lint-c's ratchet passes again (t_int_float_view.m's nullability finding from f083873) (PR #1338) clang-tidy's clang-analyzer-nullability.NullablePassedToNonnull flagged t_int_float_view.m: it passed unchecked results of MTLCreateSystemDefaultDevice, newTextureWithDescriptor, newTextureViewWithPixelFormat, newFunctionWithName and the encoder calls into later calls. Each is now checked, printing a message and returning 1, as ad7af9c did for the other Metal tests. What the test checks is unchanged. Co-authored-by: Oliver Ames <7366664+oliverames@users.noreply.github.com>
Owner
|
Landed unchanged as 671c68e (credited as co-author). Checked here: |
2 tasks done
Know-It-All-Brother
pushed a commit
to Know-It-All-Brother/nxnative
that referenced
this pull request
Nov 9, 2026
…ake before using them: lint-c's ratchet passes again (t_int_float_view.m's nullability finding from 0f50468) (PR seedds#1338) clang-tidy's clang-analyzer-nullability.NullablePassedToNonnull flagged t_int_float_view.m: it passed unchecked results of MTLCreateSystemDefaultDevice, newTextureWithDescriptor, newTextureViewWithPixelFormat, newFunctionWithName and the encoder calls into later calls. Each is now checked, printing a message and returning 1, as 68dfbed did for the other Metal tests. What the test checks is unchanged. Co-authored-by: Oliver Ames <7366664+oliverames@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
clang-tidy's nullability check (`clang-analyzer-nullability.NullablePassedToNonnull`) flags `dm/gfx/tests/t_int_float_view.m`, which f083873 introduced. The test passes unchecked results of `MTLCreateSystemDefaultDevice`, `newTextureWithDescriptor`, `newTextureViewWithPixelFormat`, the command queue, buffer, encoder and shader-function calls into later calls. The ratchet then fails lint-c on main, and every PR that touches `dm/host` or `dm/gfx` inherits the failure.
This adds the same kind of nil checks that ad7af9c added to the other Metal tests. Each check prints a message and returns 1. The test's checks and expected values are unchanged.
Verification