Repository navigation
Fix nullable mesh-stage parameter parsing and Python CI - #1154
Closed
oliverames wants to merge 1 commit into
Closed
oliverames wants to merge 1 commit into
oliverames wants to merge 1 commit into
Conversation
2 of 3 tasks
This was referenced Nov 4, 2026
Contributor
Author
|
Closing as superseded by the maintainer's e556f7a, which handles unnamed mesh-stage parameters with ValueError and includes a regression. Current main a70f071 additionally includes this helper in the shader cache and chain inputs. I verified 24 mesh-stage tests and six Xcode workflow tests on that implementation. The completed Tool tests failure on this older PR was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_stage()indexes a nullable regex match while extracting kernel parameter names, causing the Python ratchet failure on main. A synthetic unreadable parameter also reproduces an uncaughtTypeError;dmsh_build.pyexpectsValueErrorto reportmesh stage failed.Check the match and raise that existing error type with the offending parameter. Add a focused rejection test and document the error path. Valid generated shader output is unchanged. This is a CI/parser fix found while preparing the physical-iPhone regression runner in #1153, not a claimed DKB or MKW performance fix.
Validation: all 24 mesh-stage tests pass, including compiling four representative task/mesh variants for macOS and iPhoneOS. The four generated MSL strings are byte-identical before/after. The full pinned Python ratchet passes (391 existing findings, zero new, zero stale); all 11 documentation tests and whitespace checks pass. The current chain tool still computes
475a55e74858, matching the header:dmsh_meshstage.pyis not among its hashed files. No game shaders or installed phone build were changed, and no game-level behavior improvement is claimed.