Skip to content

Restore module discovery in the Xcode preparation fixture - #1157

Closed
thehobbit85 wants to merge 2 commits into
seedds:mainfrom
thehobbit85:codex/xcode-profile-fixture-modules
Closed

thehobbit85 wants to merge 2 commits into
seedds:mainfrom
thehobbit85:codex/xcode-profile-fixture-modules

Conversation

@thehobbit85

Copy link
Copy Markdown
Contributor

What and why

The derived-profile --prepare-xcode cases abort on main because their fixture lacks Game.modules_in(), which the preparation pipeline now calls. Delegate module discovery to the registered profile, as the fixture already does for get and words. This restores the NVN, Vulkan and OpenGL derived cases while preserving all existing assertions.

The fixture repair is isolated in 1dd3b30d. It was found while checking #1155 and is submitted separately from that NARC change.

Prerequisite: this branch carries the unchanged fix from #1154 (9b6113bad, preserving Oliver Ames's authorship). Main separately fails its Python ratchet on that nullable mesh-stage regex match. #1154 remains the upstream fix for that issue; the fixture commit can be applied independently once it lands.

Checked

  • Reproduced all three derived-case AttributeError failures on pinned main 75e5ddd8; the complete Xcode workflow file passes after the fixture change.
  • Final combined branch: all 94 tool/iOS test files pass, each in a fresh process: 1,042 tests, 24 skipped. macOS 26.6 (25G5028f), Apple Silicon, Python 3.14.6. Mac app packaging tests used normal macOS service access; a sandboxed attempt stopped in iconutil.
  • Pinned full Python ratchet: 391 existing findings, zero new, zero stale.
  • Mesh-stage suite: 23 pass; one compiler-dependent test is blocked by the missing local Metal Toolchain, also confirmed by xcrun metal --version. The malformed-parameter regression errors on main and passes with the prerequisite; four representative generated MSL strings are byte-identical before/after.
  • dmsh_chain.py --header remains 475a55e74858; the symptom index and whitespace checks are current.
  • No games or devices were run. The new change is a test-fixture interface repair; the prerequisite's validation is synthetic. No gameplay or full shader-library validation is claimed.

Docs

@github-actions github-actions Bot added nvn NVN on Metal and its tests (dm/gfx/nvn, dm/gfx/tests) ios The iPhone and iPad app (dm/ios) docs Documentation labels Nov 4, 2026
@seedds

seedds commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Thanks for tracking down the fixture failure. e556f7a1 now delegates modules_in to the registered profile and includes the mesh-stage parameter guard on main. The focused Xcode workflow and mesh-stage suites passed on current main. Closing because both fixes are already upstream.

@seedds seedds closed this Nov 4, 2026
@thehobbit85
thehobbit85 deleted the codex/xcode-profile-fixture-modules branch November 4, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation ios The iPhone and iPad app (dm/ios) nvn NVN on Metal and its tests (dm/gfx/nvn, dm/gfx/tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants