Repository navigation
Restore module discovery in the Xcode preparation fixture - #1157
Closed
thehobbit85 wants to merge 2 commits into
Closed
thehobbit85 wants to merge 2 commits into
thehobbit85 wants to merge 2 commits into
Conversation
Owner
|
Thanks for tracking down the fixture failure. e556f7a1 now delegates |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The derived-profile
--prepare-xcodecases abort on main because their fixture lacksGame.modules_in(), which the preparation pipeline now calls. Delegate module discovery to the registered profile, as the fixture already does forgetandwords. This restores the NVN, Vulkan and OpenGL derived cases while preserving all existing assertions.The fixture repair is isolated in
1dd3b30d. It was found while checking #1155 and is submitted separately from that NARC change.Prerequisite: this branch carries the unchanged fix from #1154 (
9b6113bad, preserving Oliver Ames's authorship). Main separately fails its Python ratchet on that nullable mesh-stage regex match. #1154 remains the upstream fix for that issue; the fixture commit can be applied independently once it lands.Checked
AttributeErrorfailures on pinned main75e5ddd8; the complete Xcode workflow file passes after the fixture change.iconutil.xcrun metal --version. The malformed-parameter regression errors on main and passes with the prerequisite; four representative generated MSL strings are byte-identical before/after.dmsh_chain.py --headerremains475a55e74858; the symptom index and whitespace checks are current.Docs