Repository navigation
docs: 🏗️ add Rust interface design for get() - #247
Open
lwjohnst86 wants to merge 22 commits into
Open
lwjohnst86 wants to merge 22 commits into
lwjohnst86 wants to merge 22 commits into
Conversation
1 task done
lwjohnst86
force-pushed
the
docs/add-rust-design-get
branch
4 times, most recently
from
November 6, 2026 10:21
7468b81 to
e677834
Compare
signekb
requested changes
Nov 10, 2026
signekb
left a comment
Member
There was a problem hiding this comment.
This seems (at least on the surface) pretty straightforward. I have some suggestions:
lwjohnst86
force-pushed
the
docs/add-rust-design-get
branch
from
November 10, 2026 10:06
ab740cd to
d2862f9
Compare
fruvago
requested changes
Nov 11, 2026
Co-authored-by: Daniel Mazhari-Jensen <120712445+DanMazJen@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com> Co-authored-by: fruvago <57952344+fruvago@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
lwjohnst86
force-pushed
the
docs/add-rust-design-get
branch
from
November 11, 2026 09:49
903cca8 to
fbf6c8b
Compare
fruvago
requested changes
Nov 13, 2026
fruvago
left a comment
Contributor
There was a problem hiding this comment.
Nice, just some small things.
Comment on lines
+275
to
+276
| Uses the `ZendoId` to find the matching deposit within the `related_identifier` | ||
| Zenodo field. If it doesn't find one, it outputs `None`. If there are duplicate |
Contributor
There was a problem hiding this comment.
Suggested change
| Uses the `ZendoId` to find the matching deposit within the `related_identifier` | |
| Zenodo field. If it doesn't find one, it outputs `None`. If there are duplicate | |
| Uses the `ZendoId` to find the matching deposit. | |
| If it doesn't find one, it outputs `None`. If there are duplicate |
Because we match on zendo_id == deposit.zendo_id
Member
Author
There was a problem hiding this comment.
hmm, how would the deposit on Zenodo have zendo_id? That's something only we have.
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
…e-project/zen-do into docs/add-rust-design-get
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Potential design for
get().Needs a thorough review.
Checklist
just run-all