Skip to content

docs: 🏗️ add Rust interface design for get() - #247

Open
lwjohnst86 wants to merge 22 commits into
docs/add-rust-design-discardfrom
docs/add-rust-design-get
Open

lwjohnst86 wants to merge 22 commits into
docs/add-rust-design-discardfrom
docs/add-rust-design-get

Conversation

@lwjohnst86

Copy link
Copy Markdown
Member

Description

Potential design for get().

Needs a thorough review.

Checklist

  • Ran just run-all

@lwjohnst86
lwjohnst86 requested a review from a team as a code owner November 2, 2026 08:40
@lwjohnst86
lwjohnst86 added this pull request to stack #251 November 2, 2026 08:47
@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Product development Nov 2, 2026
@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-get branch 4 times, most recently from 7468b81 to e677834 Compare November 6, 2026 10:21

@signekb signekb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems (at least on the surface) pretty straightforward. I have some suggestions:

Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 10, 2026
@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-get branch from ab740cd to d2862f9 Compare November 10, 2026 10:06
@lwjohnst86
lwjohnst86 requested a review from signekb November 10, 2026 10:10
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Product development Nov 10, 2026
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 11, 2026
lwjohnst86 and others added 9 commits November 11, 2026 10:38
Co-authored-by: Daniel Mazhari-Jensen <120712445+DanMazJen@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: fruvago <57952344+fruvago@users.noreply.github.com>
@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-get branch from 903cca8 to fbf6c8b Compare November 11, 2026 09:49
@lwjohnst86
lwjohnst86 requested a review from fruvago November 12, 2026 18:15
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Product development Nov 12, 2026

@fruvago fruvago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some small things.

Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment on lines +275 to +276
Uses the `ZendoId` to find the matching deposit within the `related_identifier`
Zenodo field. If it doesn't find one, it outputs `None`. If there are duplicate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Uses the `ZendoId` to find the matching deposit within the `related_identifier`
Zenodo field. If it doesn't find one, it outputs `None`. If there are duplicate
Uses the `ZendoId` to find the matching deposit.
If it doesn't find one, it outputs `None`. If there are duplicate

Because we match on zendo_id == deposit.zendo_id

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, how would the deposit on Zenodo have zendo_id? That's something only we have.

@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 13, 2026
@lwjohnst86
lwjohnst86 requested a review from fruvago November 16, 2026 16:31
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Product development Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants