Repository navigation
docs: 🏗️ add Rust interface design for list() - #248
Open
lwjohnst86 wants to merge 6 commits into
Open
lwjohnst86 wants to merge 6 commits into
lwjohnst86 wants to merge 6 commits into
Conversation
lwjohnst86
force-pushed
the
docs/add-rust-design-list
branch
3 times, most recently
from
November 3, 2026 13:58
967601a to
2d33213
Compare
signekb
requested changes
Nov 4, 2026
signekb
left a comment
Member
There was a problem hiding this comment.
This is (and the other design PRs) are going to be suuuper helpful this iteration, so thank you! 🌟 Some minor suggestions:
signekb
reviewed
Nov 4, 2026
lwjohnst86
force-pushed
the
docs/add-rust-design-list
branch
from
November 6, 2026 10:21
2d33213 to
9279649
Compare
signekb
requested changes
Nov 9, 2026
signekb
left a comment
Member
There was a problem hiding this comment.
Very minor, otherwise approved 🌷
Member
|
@lwjohnst86 Seems that the pre-commit ci fails atm? |
lwjohnst86
force-pushed
the
docs/add-rust-design-list
branch
from
November 10, 2026 10:06
ba90183 to
75356a8
Compare
fruvago
previously approved these changes
Nov 11, 2026
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
lwjohnst86
force-pushed
the
docs/add-rust-design-list
branch
from
November 11, 2026 09:49
558d27f to
a5ce1da
Compare
signekb
requested changes
Nov 12, 2026
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
fruvago
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The internal library function is described in #247.
Needs a thorough review.
Diagram Kroki preview here
Checklist
just run-all