Skip to content

docs: 🏗️ add Rust interface design for list() - #248

Open
lwjohnst86 wants to merge 6 commits into
docs/add-rust-design-getfrom
docs/add-rust-design-list
Open

lwjohnst86 wants to merge 6 commits into
docs/add-rust-design-getfrom
docs/add-rust-design-list

Conversation

@lwjohnst86

@lwjohnst86 lwjohnst86 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Description

The internal library function is described in #247.

Needs a thorough review.

Diagram Kroki preview here

Checklist

  • Ran just run-all

@lwjohnst86
lwjohnst86 requested a review from a team as a code owner November 2, 2026 08:43
@lwjohnst86
lwjohnst86 added this pull request to stack #251 November 2, 2026 08:47
@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Product development Nov 2, 2026
@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-list branch 3 times, most recently from 967601a to 2d33213 Compare November 3, 2026 13:58

@signekb signekb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is (and the other design PRs) are going to be suuuper helpful this iteration, so thank you! 🌟 Some minor suggestions:

Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 4, 2026
Comment thread docs/design/interface/rust.qmd Resolved
@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-list branch from 2d33213 to 9279649 Compare November 6, 2026 10:21
@lwjohnst86
lwjohnst86 requested a review from signekb November 6, 2026 13:43
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Product development Nov 6, 2026

@signekb signekb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor, otherwise approved 🌷

Comment thread docs/design/interface/rust.qmd Resolved
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 9, 2026
@lwjohnst86
lwjohnst86 requested a review from signekb November 10, 2026 07:39
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Product development Nov 10, 2026
@signekb

signekb commented Nov 10, 2026

Copy link
Copy Markdown
Member

@lwjohnst86 Seems that the pre-commit ci fails atm?

@lwjohnst86
lwjohnst86 force-pushed the docs/add-rust-design-list branch from ba90183 to 75356a8 Compare November 10, 2026 10:06
fruvago
fruvago previously approved these changes Nov 11, 2026
lwjohnst86 and others added 5 commits November 11, 2026 10:44
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>

@signekb signekb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request -> Session

Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
Comment thread docs/design/interface/rust.qmd Resolved
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Product development Nov 12, 2026
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 moved this from In Progress to Approved in Product development Nov 12, 2026
@lwjohnst86 lwjohnst86 moved this from Approved to In Review in Product development Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants