test(backed): add regression for filename=None after read_h5ad#2517
Open
SID-6921 wants to merge 2 commits into
Open
test(backed): add regression for filename=None after read_h5ad#2517SID-6921 wants to merge 2 commits into
SID-6921 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2517 +/- ##
==========================================
- Coverage 87.66% 85.71% -1.96%
==========================================
Files 49 49
Lines 7729 7729
==========================================
- Hits 6776 6625 -151
- Misses 953 1104 +151 |
Signed-off-by: SID <nandasiddhardha@gmail.com>
Author
|
I pushed a follow-up commit to satisfy pre-commit linting on the new regression test. Current failing checks are triage gates (Triage: Check PR title, milestone, and labels and Triage: Check if GPU tests are allowed to run), which I can’t resolve from a fork. Could a maintainer please help set the required labels/milestone and triage permissions? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression coverage for switching from backed mode to memory mode when loading with
ead_h5ad(..., backed='r+') and then setting �data.filename = None.
Details
Validation
Refs #623