Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/623.fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix setting {attr}`anndata.AnnData.filename` to {obj}`None` for backed objects so {attr}`anndata.AnnData.raw` keeps {attr}`~anndata.Raw.X` in memory {user}`ehsanestaji`
4 changes: 3 additions & 1 deletion src/anndata/_core/file_backing.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,9 @@ def close(self):

def _to_memory_mode(self):
"""Close the backing file, forget filename, *do* change to memory mode."""
self._adata.X = self._adata.X[()]
if self._adata.raw is not None:
self._adata.raw._X = to_memory(self._adata.raw.X)
self._adata.X = to_memory(self._adata.X)
self._file.close()
self._file = None
self._filename = None
Expand Down
13 changes: 13 additions & 0 deletions tests/test_backed_hdf5.py
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,19 @@ def test_return_to_memory_mode(adata: ad.AnnData, backing_h5ad: Path):
bdata.filename = None


def test_return_to_memory_mode_loads_raw_X(adata: ad.AnnData, backing_h5ad: Path):
adata.raw = adata.copy()
expected_raw_X = asarray(adata.raw.X)
adata.write_h5ad(backing_h5ad)
backed = ad.read_h5ad(backing_h5ad, backed="r")
assert backed.isbacked

backed.filename = None
assert not backed.isbacked
assert backed.raw.X is not None
assert np.array_equal(asarray(backed.raw.X), expected_raw_X)


def test_backed_modification(adata: ad.AnnData, backing_h5ad: Path):
adata.X[:, 1] = 0 # Make it a little sparse
adata.X = sparse.csr_matrix(adata.X)
Expand Down
Loading