fix: scalar setting/reshape on CoW .X#2340
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.12.x #2340 +/- ##
==========================================
+ Coverage 84.82% 86.89% +2.06%
==========================================
Files 46 46
Lines 7251 7259 +8
==========================================
+ Hits 6151 6308 +157
+ Misses 1100 951 -149
|
flying-sheep
approved these changes
Feb 12, 2026
Member
Hmm, maybe only if X is not Anyway, I don’t have a strong opinion here |
Contributor
Author
That's a good point. But then what if it's sparse? We do a dense-sparse matrix? I think I will add a warning that setting via scalars (and reshaping) will be deprecated at some point and for now it is |
…ta into ig/backport_reshape_scalar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@flying-sheep I'm ready to merge #2338 but noticed I hadn't backported this feature with the
CoWbranch. I'm actually not even 100% sure we should support these shortcuts. WDYT? I'll hold off on merging the other PR until I hear back.