Skip to content

chore: add anndata.settings.copy_on_write_X#2327

Merged
ilan-gold merged 23 commits into
mainfrom
ig/cow_x
Feb 6, 2026
Merged

chore: add anndata.settings.copy_on_write_X#2327
ilan-gold merged 23 commits into
mainfrom
ig/cow_x

Conversation

@ilan-gold

@ilan-gold ilan-gold commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

copy_on_write_X will be False and then the setting will be removed in the next minor release (i.e., True).

@codecov

codecov Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.62%. Comparing base (26478f0) to head (5375787).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
src/anndata/_core/anndata.py 93.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2327      +/-   ##
==========================================
- Coverage   86.72%   84.62%   -2.10%     
==========================================
  Files          46       46              
  Lines        7165     7182      +17     
==========================================
- Hits         6214     6078     -136     
- Misses        951     1104     +153     
Files with missing lines Coverage Δ
src/anndata/_settings.py 92.85% <100.00%> (+0.04%) ⬆️
src/anndata/_core/anndata.py 83.68% <93.87%> (+0.33%) ⬆️

... and 8 files with indirect coverage changes

Comment thread src/anndata/_core/anndata.py Outdated
@ilan-gold ilan-gold mentioned this pull request Feb 4, 2026
6 tasks
Comment thread src/anndata/_core/anndata.py
@ilan-gold ilan-gold marked this pull request as ready for review February 4, 2026 15:14
@ilan-gold

Copy link
Copy Markdown
Contributor Author

Tested locally against scanpy and getting no warnings. I also ctrl+F'ed the codebase and don't see anywhere this might be triggered anyway.

@flying-sheep flying-sheep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, very few code changes necessary!

Do please reduce complexity instead of adding more ignores for complexity warnings though.

Comment thread tests/test_x.py Outdated
Comment thread tests/test_x.py Outdated
Comment thread src/anndata/_settings.py Outdated
Comment thread src/anndata/_core/anndata.py
Comment thread src/anndata/_core/anndata.py Outdated
Co-authored-by: Philipp A. <flying-sheep@web.de>
@ilan-gold ilan-gold enabled auto-merge (squash) February 6, 2026 08:55
@ilan-gold ilan-gold merged commit c933d12 into main Feb 6, 2026
21 checks passed
@ilan-gold ilan-gold deleted the ig/cow_x branch February 6, 2026 09:09
ilan-gold added a commit that referenced this pull request Feb 6, 2026
Co-authored-by: Philipp A. <flying-sheep@web.de>
(cherry picked from commit c933d12)
ilan-gold added a commit that referenced this pull request Feb 6, 2026
Co-authored-by: Philipp A. <flying-sheep@web.de>
@scverse scverse deleted a comment from lumberbot-app Bot Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants