Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 86.72% 84.62% -2.10%
==========================================
Files 46 46
Lines 7165 7182 +17
==========================================
- Hits 6214 6078 -136
- Misses 951 1104 +153
|
Zethson
reviewed
Feb 4, 2026
ilan-gold
commented
Feb 4, 2026
Contributor
Author
|
Tested locally against scanpy and getting no warnings. I also |
flying-sheep
requested changes
Feb 5, 2026
flying-sheep
left a comment
Member
There was a problem hiding this comment.
Awesome, very few code changes necessary!
Do please reduce complexity instead of adding more ignores for complexity warnings though.
Co-authored-by: Philipp A. <flying-sheep@web.de>
flying-sheep
approved these changes
Feb 5, 2026
ilan-gold
added a commit
that referenced
this pull request
Feb 6, 2026
Co-authored-by: Philipp A. <flying-sheep@web.de> (cherry picked from commit c933d12)
ilan-gold
added a commit
that referenced
this pull request
Feb 6, 2026
Co-authored-by: Philipp A. <flying-sheep@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy_on_write_Xwill beFalseand then the setting will be removed in the next minor release (i.e.,True).X